chore: update upstream code #6

ritz078 · 2025-04-10T11:16:26Z

Closes

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

* Fix generated code sample for S2 TooltipTrigger docs * review * inlining

…trum into develop

…adobe#7976) * Initial refactor to tear out UNSTABLE_portalContainer in favor of the PortalContainer * yarn.lock update * switch to deprecating UNSTABLE_portalContainer * prefer deprecated prop over context to make this a non-breaking change * add rough docs * updating copy to include explaination of UNSTABLE * rename to UNSAFE_PortalProvider * update copy and split out example * use styles from RAC examples --------- Co-authored-by: Robert Snow <[email protected]>

…e#7974) * Add disallowClearAll to Menu/ListBox so Autocomplete in Popover can close without clearing selection * add support for diallowClearAll to grid/tree/table * make sure RSP components also surface disallowClearAll * update api naming to escapeKeyBehavior * skip 17 tests for build, investigate later * review comments

* fix: minor typo in CalendarDate docs * fix second example as well --------- Co-authored-by: Robert Snow <[email protected]>

* chore: update typescript to 5.8 * fix all the types for the upgrade * fix numberfield styles

* fix: Apply touch-action by default in usePress * fix test --------- Co-authored-by: Daniel Lu <[email protected]>

) * attempt to get rid of jest calls in menu util * update RSP testing docs to directly mention mocks that maybe needed * bump versions of RTL to 16 * use alternative to calling jest run timers in menu option selection * fixing types and properly testing long press * fix lint * revert to pre testing library bump for clean slate * fix build and another submenu edge case now we shouldnt need to call runAllTimers after selectOption * fix react 16 bug * update return type of advanceTimer and docs copy * move some general fixes from selectionMode="replace" branch here * get rid of unneeded async * getting rid of extraneous dep * fix lint

* fix: add static color to s2 notification badge * make opaque * updates * use locale * fix lint --------- Co-authored-by: Robert Snow <[email protected]>

* Latest translations * Translation correction * Couple of translation corrections * Remove å from Norwegian string --------- Co-authored-by: Yihui Liao <[email protected]>

…dobe#8006) Co-authored-by: Danni <[email protected]>

* chore: audit 3.41 * remove deprecation

…trum into develop

…itesh/up-apr

…t-aria-components * Added @react-aria/ssr and updated @react-aria/overlays in @react-aria/overlays package.json * Added @react-aria/overlays, @react-aria/ssr, and @react-aria/utils in @react-aria-components package.json

* Refactored import statements in various components and tests to use @react-aria-nutrient/overlays instead of @react-aria/overlays. * Removed references to @react-aria/overlays from package.json and yarn.lock. * Updated documentation links to reflect the new package structure.

* Refactored import statements in TableTests.js to replace @react-aria with @react-aria-nutrient for live-announcer, utils, and focus modules. * Ensured consistency with recent package structure changes.

* Ensured proper formatting by adding a newline at the end of Table.test.js and TestTableUtils.test.tsx files to comply with best practices.

Copilot

Copilot reviewed 121 out of 127 changed files in this pull request and generated no comments.

Files not reviewed (6)

package.json: Language not supported
packages/@internationalized/date/docs/CalendarDate.mdx: Language not supported
packages/@react-aria/overlays/docs/PortalProvider.mdx: Language not supported
packages/@react-aria/overlays/package.json: Language not supported
packages/@react-aria/table/intl/es-ES.json: Language not supported
packages/@react-aria/test-utils/package.json: Language not supported

Comments suppressed due to low confidence (2)

packages/@react-aria/interactions/src/useMove.ts:96

The updated condition may bypass the intended test fallback when PointerEvent is defined in a test environment. Please verify that all test scenarios use the correct pointer event handling.

if (typeof PointerEvent === 'undefined' && process.env.NODE_ENV === 'test') {

packages/@react-aria/collections/src/Document.ts:465

[nitpick] After removing disconnected or hidden nodes in the first loop, these nodes might still appear in the subsequent iteration over dirtyNodes. Consider ensuring they are fully filtered out to avoid any unnecessary processing.

if (element instanceof ElementNode && (!element.isConnected || element.isHidden)) {

* chore: Fix generated code sample for S2 TooltipTrigger docs (adobe#8000) * Fix generated code sample for S2 TooltipTrigger docs * review * inlining * fix: export SortDescriptor type from S2 (adobe#8030) * chore: Deprecate UNSTABLE_portalContainer in favor for PortalProvider (adobe#7976) * Initial refactor to tear out UNSTABLE_portalContainer in favor of the PortalContainer * yarn.lock update * switch to deprecating UNSTABLE_portalContainer * prefer deprecated prop over context to make this a non-breaking change * add rough docs * updating copy to include explaination of UNSTABLE * rename to UNSAFE_PortalProvider * update copy and split out example * use styles from RAC examples --------- Co-authored-by: Robert Snow <[email protected]> * feat: Add escapeKeyBehavior to GridList/ListBox/Menu/Table/Tree (adobe#7974) * Add disallowClearAll to Menu/ListBox so Autocomplete in Popover can close without clearing selection * add support for diallowClearAll to grid/tree/table * make sure RSP components also surface disallowClearAll * update api naming to escapeKeyBehavior * skip 17 tests for build, investigate later * review comments * fix: useMove broken by NODE_ENV check (adobe#8046) * fix: ColorWheel track click (adobe#8049) * fix: minor typo in CalendarDate docs (adobe#8043) * fix: minor typo in CalendarDate docs * fix second example as well --------- Co-authored-by: Robert Snow <[email protected]> * fix: Updating collection when items change parents (adobe#8052) * export Autocomplete from S2 (adobe#8050) * chore: Optimize table test performance (adobe#8051) * chore: Update typescript to 5.8 (adobe#7888) * chore: update typescript to 5.8 * fix all the types for the upgrade * fix numberfield styles * fix: Apply touch-action by default in usePress (adobe#8047) * fix: Apply touch-action by default in usePress * fix test --------- Co-authored-by: Daniel Lu <[email protected]> * fix: set some better flex behaviour (adobe#8048) * fix: Support React 19 and remove Jest reliance in test utils (adobe#7686) * attempt to get rid of jest calls in menu util * update RSP testing docs to directly mention mocks that maybe needed * bump versions of RTL to 16 * use alternative to calling jest run timers in menu option selection * fixing types and properly testing long press * fix lint * revert to pre testing library bump for clean slate * fix build and another submenu edge case now we shouldnt need to call runAllTimers after selectOption * fix react 16 bug * update return type of advanceTimer and docs copy * move some general fixes from selectionMode="replace" branch here * get rid of unneeded async * getting rid of extraneous dep * fix lint * chore: revert ts update (adobe#8060) * fix: add static color to s2 notification badge (adobe#8055) * fix: add static color to s2 notification badge * make opaque * updates * use locale * fix lint --------- Co-authored-by: Robert Snow <[email protected]> * chore: Latest translations (adobe#8036) * Latest translations * Translation correction * Couple of translation corrections * Remove å from Norwegian string --------- Co-authored-by: Yihui Liao <[email protected]> * fix: Relax Parcel version range in public plugins (adobe#8067) * Disclosure button label size update to match new sizes from Specturm (adobe#8006) Co-authored-by: Danni <[email protected]> * chore: audit 3.41 (adobe#8064) * chore: audit 3.41 * remove deprecation * chore: audit 3.41 (adobe#8064) * chore: audit 3.41 * remove deprecation * chore: Update package dependencies for @react-aria/overlays and @react-aria-components * Added @react-aria/ssr and updated @react-aria/overlays in @react-aria/overlays package.json * Added @react-aria/overlays, @react-aria/ssr, and @react-aria/utils in @react-aria-components package.json * chore: Update import paths and dependencies for @react-aria-nutrient * Refactored import statements in various components and tests to use @react-aria-nutrient/overlays instead of @react-aria/overlays. * Removed references to @react-aria/overlays from package.json and yarn.lock. * Updated documentation links to reflect the new package structure. * chore: Update import paths in TableTests to use @react-aria-nutrient * Refactored import statements in TableTests.js to replace @react-aria with @react-aria-nutrient for live-announcer, utils, and focus modules. * Ensured consistency with recent package structure changes. * fix: Add missing newline at end of test files * Ensured proper formatting by adding a newline at the end of Table.test.js and TestTableUtils.test.tsx files to comply with best practices. --------- Co-authored-by: Daniel Lu <[email protected]> Co-authored-by: Trevor Howell <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Devon Govett <[email protected]> Co-authored-by: DarkstarXDD <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Yihui Liao <[email protected]> Co-authored-by: Richard Geraghty <[email protected]> Co-authored-by: Kyle Taborski <[email protected]> Co-authored-by: Danni <[email protected]>

LFDanLu and others added 28 commits April 3, 2025 20:06

chore: Fix generated code sample for S2 TooltipTrigger docs (adobe#8000)

f75223a

* Fix generated code sample for S2 TooltipTrigger docs * review * inlining

fix: export SortDescriptor type from S2 (adobe#8030)

148fcf1

Merge branch 'develop' of https://github.com/PSPDFKit-labs/react-spec…

8ea86b7

…trum into develop

fix: useMove broken by NODE_ENV check (adobe#8046)

5e7a5af

fix: ColorWheel track click (adobe#8049)

ad4681f

fix: minor typo in CalendarDate docs (adobe#8043)

7e7e33d

* fix: minor typo in CalendarDate docs * fix second example as well --------- Co-authored-by: Robert Snow <[email protected]>

fix: Updating collection when items change parents (adobe#8052)

8fbe17f

export Autocomplete from S2 (adobe#8050)

4bcf541

chore: Optimize table test performance (adobe#8051)

2edef89

chore: Update typescript to 5.8 (adobe#7888)

fd7b5dd

* chore: update typescript to 5.8 * fix all the types for the upgrade * fix numberfield styles

fix: Apply touch-action by default in usePress (adobe#8047)

68c67d4

* fix: Apply touch-action by default in usePress * fix test --------- Co-authored-by: Daniel Lu <[email protected]>

fix: set some better flex behaviour (adobe#8048)

5dcf9ce

chore: revert ts update (adobe#8060)

c81a23c

fix: add static color to s2 notification badge (adobe#8055)

04b9fe1

* fix: add static color to s2 notification badge * make opaque * updates * use locale * fix lint --------- Co-authored-by: Robert Snow <[email protected]>

chore: Latest translations (adobe#8036)

d93947e

* Latest translations * Translation correction * Couple of translation corrections * Remove å from Norwegian string --------- Co-authored-by: Yihui Liao <[email protected]>

fix: Relax Parcel version range in public plugins (adobe#8067)

77589c2

Disclosure button label size update to match new sizes from Specturm (a…

12180a0

…dobe#8006) Co-authored-by: Danni <[email protected]>

chore: audit 3.41 (adobe#8064)

631eb85

* chore: audit 3.41 * remove deprecation

chore: audit 3.41 (adobe#8064)

58d96ca

* chore: audit 3.41 * remove deprecation

Merge branch 'develop' of https://github.com/PSPDFKit-labs/react-spec…

921e1c2

…trum into develop

Merge branch 'main' of https://github.com/adobe/react-spectrum into r…

b509ed4

…itesh/up-apr

chore: Update import paths in TableTests to use @react-aria-nutrient

125e24e

* Refactored import statements in TableTests.js to replace @react-aria with @react-aria-nutrient for live-announcer, utils, and focus modules. * Ensured consistency with recent package structure changes.

fix: Add missing newline at end of test files

c97d574

* Ensured proper formatting by adding a newline at the end of Table.test.js and TestTableUtils.test.tsx files to comply with best practices.

ritz078 marked this pull request as ready for review April 10, 2025 12:20

Copilot AI review requested due to automatic review settings April 10, 2025 12:20

ritz078 merged commit 1c5aad9 into develop Apr 10, 2025
10 checks passed

Copilot AI reviewed Apr 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: update upstream code #6

chore: update upstream code #6

Uh oh!

ritz078 commented Apr 10, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

chore: update upstream code #6

chore: update upstream code #6

Uh oh!

Conversation

ritz078 commented Apr 10, 2025

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!