Update tree data and asset handeling #8295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
added
enhancement
Wires77
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Why does the 3.19 Assets become the generic one, but we also have a 3_19.lua file now?
There was a problem hiding this comment.
Can we name this folder "sprites" instead of "data"? I had to look at where they were moved from to make sense of it.
| -- Retrieve the file at the given Path | ||
| local function getFile(Path, altPath) | ||
| local text | ||
| local File = io.open("TreeData/"..Path..".lua", "r") |
There was a problem hiding this comment.
nit: Can we keep variable names lowercased if they are just an instance of a class?
Suggested change
| local File = io.open("TreeData/"..Path..".lua", "r") | |
| local file = io.open("TreeData/"..Path..".lua", "r") |
| -- Migrate to old format | ||
| class.classes = class.ascendancies | ||
| end | ||
| class.classes = class.classes or class.ascendancies |
There was a problem hiding this comment.
Maybe leave a comment in there explaining why this logic is here
Comment on lines
+441
to
+444
| self.legion = main.tree.legion | ||
| if not self.legion then | ||
| self.legion = LoadModule("Data/TimelessJewelData/LegionPassives") | ||
|
|
There was a problem hiding this comment.
Is this logic just for being able to skip these loops if the legion nodes have already been loaded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"minor" rework to how we handle and store tree data and assets
The 4 main goals with this are to
src\TreeData\assets\non_spritestill having alot of loose files, this can be cleaned up more if desired)There are many other changes that could improve this more, eg not having to redo spritesheets which are duplicates across multiple tree versions, but I have decided to limit the scope of this a bit to make it easier to merge
I have a followup PR which moves most of the logic over to use spritesheets (that were introduced in 3.19), but again I have decided to limit the scope of this a bit to make it easier to merge, and will open that PR once this is merged