Skip to content

Fix Wretched Defiler missing skill types #8707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

leotianlizhan
Copy link

@leotianlizhan leotianlizhan commented Jun 21, 2025

Wretched Defilers do not work with many skill gems due to missing skill types

Fixes # .

Description of the problem being solved:

Wretched Defiler's skill doesn't work with gems like Controlled Destruction and Spell Echo for some reason, even though Spell Echo clearly works in game. I looked at the spectre.lua file and compared the skill to another spectre's skill that do work with those support gems (Forged Frostbearer), and found it's missing [SkillType.Damage] = true, [SkillType.Multicastable] = true, . Added those to skillTypes and it worked (see screenshots below)

I'm not familiar with how the export works, I assume #addSkillTypes Damage Multicastable is all I need to fix this during the next export script run? I didn't run it either. Please advise.

Steps taken to verify a working solution:

  • Add [SkillType.Damage] = true, [SkillType.Multicastable] = true, to skillTypes in Data/skills/spectre.lua
  • Verify in PoB that hovering the support skill checkbox shows DPS increase
  • Don't know how export files work, please advise if it's correct

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

Wretched Defilers do not work with many skill gems due to missing skill types
@Nightblade Nightblade added enhancement New feature, calculation, or mod and removed enhancement New feature, calculation, or mod labels Jun 22, 2025
@Paliak
Copy link
Contributor

Paliak commented Jun 22, 2025

What you did will work and it's what i've been using as a stopgap for a while. See referenced issues/PRs here: #4628

I've got a better solution for the skillTypes issue specifically here if you'd like to test it out

dev...Paliak:PathOfBuilding:minion-skilltype-issue#diff-242d62d8341e5cf18edf54dd28bad3479735ab18c9b3388413995d666656837d

Main thing with that patch is that i'm really not sure if it accidentally allows for supports/mods that should not apply bringing back #4628 in some form. Additionally many effects (support/active) have stats that explicitly shouldn't apply to minions and i'm not sure how to weave that into current handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants