Use harmonic mean for dual wield attack speed calc instead of average #8900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect calculation of attack speed while dual wielding.
Fixes #8898
Description of the problem being solved:
Attack speed while dual wielding is currently calculated using a simple average
(MH + OH)/2
, when a harmonic mean2 / ( 1/MH + 1/OH)
is the correct way to calculate average of attack speed. A simple average would have to be applied to the attack time to be the correct formula.More detail is in this reddit thread: https://old.reddit.com/r/pathofexile/comments/1m8ytld/big_misconception_on_dual_wielding_pob_and_wiki/
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshots:
After screenshots: