fix: correct syntax error in XAdES-EPES signature example #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a small but critical issue in the XAdES-EPES signature code example found in the README. Previously, the call to
xadesjs.Application.setEngine("NodeJS", )
was missing the requiredcrypto
argument, resulting in invalid JavaScript syntax.Changes
crypto
instance.Impact
This change ensures that users following the example can run the code successfully in a Node.js environment with
xadesjs
and@peculiar/webcrypto
.Checklist