#441 Fill not working #2837
Open
#441 Fill not working #2837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semirke
commented
Feb 21, 2017
| int sIdx = startIndex; | ||
| while(Float.isNaN(dataSet.getEntryForIndex(sIdx).getY()) | ||
| && sIdx < endIndex ) sIdx++; | ||
|
|
There was a problem hiding this comment.
I could've added a check for success.
|
Hi @semirke, I'm trying your fix as I'm affected by the same issue. |
|
Here is a quick fix for my chart-not-drawing issue: |
|
Thank you for this, but there's been changes to the repo since this. If you resolve the conflicts, then I can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a proposed to solve #441 (#441)
Basically the vanishing fillings were caused by scattered Float.NaNs.
I tested this solution with NaNs missing from the beginning, end and in between, however, to much and scattered NaNs could maybe still render a graph useless.
Ps: sorry for the in between commits, my git is a bit rusty...