Skip to content

[Minor] Make quick save happens after main loop #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TaranDahl
Copy link
Contributor

According to what ZivDero told me, saving game inside the main loop may cause corruption. So we need to move it out of the main loop.
This needs to be used together with the unmerged yrpp-spawner feature to work properly.
It needs to be discussed about how we should interact with spawner. Maybe a flag like CanUseSpawner or sth alike.
Open a draft PR to keep this in mind.

@github-actions github-actions bot added the Minor Documentation is not required label Feb 14, 2025
Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Metadorius
Copy link
Member

Is there a reason this is a draft?

@TaranDahl
Copy link
Contributor Author

Is there a reason this is a draft?

Currently, this one can not work correctly without the unmerged AutoSave feature of the spawner. Because the event handling of SaveGame in vanilla is somehow broken. As the spawner rewrote the event handling, I'm not sure what we are going to do with this one. Maybe we need a CanUseSpawner flag to check if the spawner is present, but I dunno how to add it for now.

@TaranDahl TaranDahl added the ⚙️T1 T1 maintainer review is sufficient label Feb 21, 2025
@Metadorius
Copy link
Member

@TaranDahl We have two ways of dealing with that:

  1. Copy the relevant parts from the spawner here so that if any of the spawner and Phobos are present - it works.
  2. Move the quick save command to the spawner.

What do you and others think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required ⚙️T1 T1 maintainer review is sufficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants