Skip to content

Refactor/vite playground #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor/vite playground #1244

wants to merge 2 commits into from

Conversation

pippinmole
Copy link
Collaborator

@pippinmole pippinmole commented Mar 13, 2025

Note

If you would like to help on this branch, please message me on Discord: pippin_mole

Details

This PR replaces the Parcel bundler with Vite, fixing various bugs such as segmentation faults.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

@pippinmole pippinmole marked this pull request as draft March 13, 2025 14:42
@PawelGawlikDev
Copy link

Realy cool idea. Vite is amazing tool. How long might it take to get this into production?

@pippinmole
Copy link
Collaborator Author

Realy cool idea. Vite is amazing tool. How long might it take to get this into production?

Thanks, This branch is simply a playground to see if it would be easy to refactor the codebase to use Vite instead of Parcel. I don't know much about Vite, and so if you'd like to help please let me know!

@pippinmole pippinmole marked this pull request as ready for review March 17, 2025 00:22
@pippinmole pippinmole marked this pull request as draft March 17, 2025 00:23
@ObinnaAka
Copy link

Would love this as well. Run into segmentation faults many times

@flexchar
Copy link

Have you considered looking into Bun as a compiler too? It has recently introduced React HMR and is really fast in many ways.

I already use it to compile many functions and main content scripts that Plasmo just copy-pastes into the output. I do this since at some point in the past Plasmo began lagging a lot, slow compiles, and out-dated changes (one of those stale open issues with no clear reason as to why).

That being said, thousand times thank you for doing this! Maybe we could also draw inspiration from https://github.com/wxt-dev/wxt. Recently read their entire documentation and there are a lot of nice things. Or maybe we could join forces and merge Plasmo into WXT (easier migration) and help build one universal tool to hide the pain away that browsers provide.

My two cents.

@pippinmole pippinmole added the help wanted Extra attention is needed label Mar 19, 2025
@pippinmole
Copy link
Collaborator Author

Hi @flexchar, thanks for your comment.

Have you considered looking into Bun as a compiler too?

I have not, but it's definitely an option. Will look into it

I do this since at some point in the past Plasmo began lagging a lot

Is your project quite large? Either way, I think moving from Parcel to Vite will hopefully improve performance enough for it not to matter. We will see.

That being said, thousand times thank you for doing this!

You are welcome. Please do note that this is simply a playground as I've mentioned before - I have no prior experience with Vite, and so it's all a learning experience for me. I'm also a relatively new contributor to Plasmo and so am learning the codebase too.

Help is welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants