Skip to content

[tools] Honour default-ttl in pdnsutil load-zone #15389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

This trivial mechanical PR lets pdnsutil load-zone default to the default-ttl setting as the TTL value for entries lacking a TTL, if $TTL is not set in the file being loaded.

This addresses #8494.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added the auth label Apr 3, 2025
@miodvallat miodvallat added tools and removed auth labels Apr 3, 2025
@coveralls
Copy link

coveralls commented Apr 3, 2025

Pull Request Test Coverage Report for Build 14243186746

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 65 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+11.4%) to 63.474%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/test-syncres_cc1.cc 6 89.64%
pdns/recursordist/taskqueue.cc 9 35.9%
pdns/recursordist/syncres.cc 16 80.11%
pdns/recursordist/rec-taskqueue.cc 34 40.14%
Totals Coverage Status
Change from base Build 14230500445: 11.4%
Covered Lines: 128512
Relevant Lines: 167798

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants