Skip to content

[tools] Let pdnsutil always setup a SOA-EDIT-API metadata when creating zones #15417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

This is a fix for #9096. Every time pdnsutil will create a zone, it will now put a SOA-EDIT-API metadata with a value of DEFAULT, to match what creating the zone from the API would have done.

Ok, I lied, not every time. When migrating using pdnsutil b2b-migrate, this will not be done, as this operation will copy all the existing metadata from the source (which may, on purpose, not have a SOA-EDIT-API metadata).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Apr 10, 2025

Pull Request Test Coverage Report for Build 14448840758

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 42 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.499%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-tcp.cc 1 77.43%
pdns/pollmplexer.cc 1 83.66%
ext/json11/json11.cpp 2 63.87%
pdns/dnsdistdist/dnsdist.cc 2 69.48%
pdns/rcpgenerator.cc 2 90.55%
pdns/recursordist/syncres.cc 2 80.21%
ext/lmdb-safe/lmdb-typed.hh 3 72.16%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/recursordist/aggressive_nsec.cc 4 65.8%
pdns/misc.cc 6 62.72%
Totals Coverage Status
Change from base Build 14447774126: 0.03%
Covered Lines: 128832
Relevant Lines: 168121

💛 - Coveralls

@miodvallat miodvallat force-pushed the some_other_afternoon branch from 5a03dd0 to 32bcfb3 Compare April 14, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants