dnsdist: Only set the proxy protocol payload size when actually added #15534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
miodvallat
reviewed
May 7, 2025
miodvallat
approved these changes
May 7, 2025
I can think of two cases where we got this wrong: - the query was initially assigned to a backend using the proxy protocol payload, then later restarted and assigned to a backend not using it. The proxy protocol payload size was then kept from the first assignment. - we failed to actually prepend the proxy protocol payload but the payload size was updated. Both cases could cause a corrupted payload to be sent, or an exception to be raised if the size of the proxy protocol payload was larger than the size of the initial query.
…ial value of zero Co-authored-by: Miod Vallat <[email protected]>
rgacogne
force-pushed
the
ddist-fix-invalid-proxy-protocol-payload-size
branch
from
adafc96 to
a462a3b
Compare
|
Note to self: a regression test would be nice! |
We fixed that for UDP backends in a previous commit, but this was still an issue for TCP-based backends.
|
Adding a regression test revealed that the issue was not fixed for TCP-based backends. Now fixed for TCP-backends as well, and with a regression test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
I can think of two cases where we got this wrong:
Both cases could cause a corrupted payload to be sent, or an exception to be raised if the size of the proxy protocol payload was larger than the size of the initial query.
Found while investigating #15529 but it might or might not be related.
Checklist
I have: