Change the LOG_SYSLOG_VIS parameters to include VIS_NOSLASH #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the LOG_SYSLOG_VIS parameters to include VIS_NOSLASH so that it's
possible to log slashes through to event logs - this allows, amoungst other
things, pass through of structured logging when built with that patch.
Before:
```
debug3("logging a slash: \\ hi!")"
```
would output:
```
logging a slash: \\ hi!
```
instead of the correct:
```
logging a slash: \ hi!
```
This is important to us, since a logger we care about sends correctly escaped
text through (specifically, the structured logging patch from hyperscale),
causing serialisation issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Change the LOG_SYSLOG_VIS parameters to include VIS_NOSLASH so that it's possible to log slashes through to event logs - this allows, amoungst other things, pass through of structured logging when built with that patch.
Before:
would output:
instead of the correct:
PR Context
This is important to us, since a logger we care about sends correctly escaped text through (specifically, the structured logging patch from hyperscale), causing serialisation issues. (For our build, we've made current set of hyperscale patches work on windows - there might be a few more PR's to come around a couple of those integration points, but potentially if there's a desire for anything in there to hit windows, we could do PRs for that too)