Add a filter to not query destroyed buckets in GET /buckets #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #108
Currently GET /buckets gets a list of all buckets no matter if they're in the purgatory "destroyed, but not yet eradicated" state. The problem with this is, is that some further calls that we make that are based off of that list (eg. bucket performance) will not return a result if we ask for a destroyed bucket.
This is the simplest way to fix this, as one a bucket is deleted - it immediately SHOULD immediately disappear from any o11y platform as that would be the indicator that "something is wrong", and still give you the eradication time to undo the deletion, if desired.