Build system changes, doc fixes, few attribute renames #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anything in there is effectively the old api, which is considered deprecated. The name change doesn't affect anything, because all the stuff is wildcard-imported anyway. But it prevents the documentation from being built due to circular alias errors
obsolete, should use a slurm-container solution for testing and dev
tazend
added a commit
that referenced
this pull request
Dec 28, 2024
* pyslurm.Job: add attribute run_time_remaining * pyslurm.JobStep: add run_time_remaining and elapsed_cpu_time attributes * rename __version__.py to just version.py * update doc_requirements to exclude cython 3.1.* releases * mkdocs.yml updates * move flake8 config to pyproject.toml * move away from invoking setup.py directly * build.sh: use pip install * rename pyslurm.pyx to deprecated.pyx anything in there is effectively the old api, which is considered deprecated. The name change doesn't affect anything, because all the stuff is wildcard-imported anyway. But it prevents the documentation from being built due to circular alias errors. * add first working pyslurm.spec file for building rpms * ability to provide core-count for builddocs.sh * remove configure.sh script obsolete, should use a slurm-container solution for testing and dev * remove run_tests* scripts * add cython-lint config, update flake8 config * remove cython.cfg, flake8 config is in pyproject.toml * update tox.ini * pyslurm.JobStep: rename step.alloc_cpus to step.cpus * update copyright for docs * doc: add JobStepStatistics * core job+step: fix docs
tazend
added a commit
to tazend/pyslurm
that referenced
this pull request
Dec 28, 2024
* pyslurm.Job: add attribute run_time_remaining * pyslurm.JobStep: add run_time_remaining and elapsed_cpu_time attributes * rename __version__.py to just version.py * update doc_requirements to exclude cython 3.1.* releases * mkdocs.yml updates * move flake8 config to pyproject.toml * move away from invoking setup.py directly * build.sh: use pip install * rename pyslurm.pyx to deprecated.pyx anything in there is effectively the old api, which is considered deprecated. The name change doesn't affect anything, because all the stuff is wildcard-imported anyway. But it prevents the documentation from being built due to circular alias errors. * add first working pyslurm.spec file for building rpms * ability to provide core-count for builddocs.sh * remove configure.sh script obsolete, should use a slurm-container solution for testing and dev * remove run_tests* scripts * add cython-lint config, update flake8 config * remove cython.cfg, flake8 config is in pyproject.toml * update tox.ini * pyslurm.JobStep: rename step.alloc_cpus to step.cpus * update copyright for docs * doc: add JobStepStatistics * core job+step: fix docs
tazend
added a commit
that referenced
this pull request
Jan 3, 2025
* pyslurm.Job: add attribute run_time_remaining * pyslurm.JobStep: add run_time_remaining and elapsed_cpu_time attributes * rename __version__.py to just version.py * update doc_requirements to exclude cython 3.1.* releases * mkdocs.yml updates * move flake8 config to pyproject.toml * move away from invoking setup.py directly * build.sh: use pip install * rename pyslurm.pyx to deprecated.pyx anything in there is effectively the old api, which is considered deprecated. The name change doesn't affect anything, because all the stuff is wildcard-imported anyway. But it prevents the documentation from being built due to circular alias errors. * add first working pyslurm.spec file for building rpms * ability to provide core-count for builddocs.sh * remove configure.sh script obsolete, should use a slurm-container solution for testing and dev * remove run_tests* scripts * add cython-lint config, update flake8 config * remove cython.cfg, flake8 config is in pyproject.toml * update tox.ini * pyslurm.JobStep: rename step.alloc_cpus to step.cpus * update copyright for docs * doc: add JobStepStatistics * core job+step: fix docs
|
In 4a118b6, you have removed the callable |
|
Hi @osnyx yes, it was intentional, in favor of accessing |
|
Thanks for the answer. |
|
yeah I think I need to merge the CHANGELOG of all releases together. Thinking about it again, its just confusing if previous changes are buried in older releases - doesn't make too much sense actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alloc_cpusattribute to justcpus, to be in sync withpyslurm.Jobscripts/build.shto not usesetup.py buildanymore, move topip install. Also speed up cythonizing files with proper multithreading.