Add custom semantic label for progress #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indicator semantics
This commit introduces a new optional parameter `progressSemantic` to the `IntroductionScreen` widget. This parameter allows developers to provide a custom semantic label for the progress indicator (dots or custom progress).
If `progressSemantic` is provided, it will be used to generate the semantic label. Otherwise, a default label "Page {currentPage} of {totalPages}" will be used.
This change enhances accessibility by allowing developers to provide more contextually relevant information to users relying on screen readers.
The ternary operator in the `progressSemantic` call within the `DotsIndicator` widget has been simplified. Instead of checking if `widget.progressSemantic` is not null and then calling it, it now uses the null-aware operator `?.` for a more concise and readable conditional call. The unused import `dart:nativewrappers/_internal/vm/lib/ffi_allocation_patch.dart` has also been removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this improvement the library allows the user to provide a custom semantic label for the progress indicator and announce it in his own language.
Before this change, it was always announced in English.