Skip to content

Change Kshell sorting precision to full precision #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Apr 2, 2025

Proposed changes

Having modk2 in full precision seems fixing kshell counting issue.
fixes #5384

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-serer

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@PDoakORNL
Copy link
Contributor

It's going to be a bunch of work for me to unwrap all my dependent changes from my fix and encapsulation of kcontainer. Just finish your review of my work, I didn't ask you to play coding golf with this and I've been held up for a very long time in review. My performance is not evaluated based on how small a change you can eventually figure out how to make.

@ye-luo
Copy link
Contributor Author

ye-luo commented Apr 2, 2025

It's going to be a bunch of work for me to unwrap all my dependent changes from my fix and encapsulation of kcontainer. Just finish your review of my work, I didn't ask you to play coding golf with this and I've been held up for a very long time in review. My performance is not evaluated based on how small a change you can eventually figure out how to make.

We can probably use git trick to simply revert the change #5389 included in #5406. I can facilitate the work. Are there any others PRs or branches affected by #5389?

@ye-luo ye-luo marked this pull request as draft April 3, 2025 22:16
Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not support this reversion.

@ye-luo
Copy link
Contributor Author

ye-luo commented May 5, 2025

I do not support this reversion.

This PR is left pending as it was. Will revise and clean up once your estimates get in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long range unit test failures
2 participants