-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Porting synth_qft_line
to Rust
#14161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
synth_qft_line
to Rustsynth_qft_line
to Rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good! I only have two small comments below 🙂
Pull Request Test Coverage Report for Build 14700264921Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @Barath-T! I think this is in a good shape, modulo needing to adjust the Rust-level docstrings a bit.
Fyi, I have reworked #13929 to work with CircuitData
directly (and in particular added convenience functions to append h
, cp
, cx
gates), but for your PR keeping it in terms of LnnGatesVec
is definitely better.
@alexanderivrii and @Cryoris Thank you for the review. I have updated the PR with the suggested changes. Please let me know if further refinements are needed. I'd also appreciate it if you can point me to other issues that i can contribute. Thank you in advance! :) |
@Barath-T, sorry, my suggestion in the previous review was incorrect:
is treated as a Python function, it actually needs sphinx style documentation, exactly like you had previously (thanks to @Cryoris for explaining that to me). Could you please revert this change (but keep the one to |
c933dc4
to
f4d0a59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! This looks good on my side, @Cryoris do you have any additional comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @Cryoris - do you have any further comments?
Summary
This PR ports
synth_qft_line
inqiskit/synthesis/qft/qft_decompose_lnn.py
to Rust (Closes #12245).Details and comments
The functionality remains the same and no new optimisations or logic is introduced.
Comment needed: PR #13929 introduces
SynthesisData
, which would allow for a cleaner refactoring.