-
Notifications
You must be signed in to change notification settings - Fork 19
Add decoherence and subset GHZ projection #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/QuantumSavory.jl/QuantumSavory.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 72.58% 63.08% -9.50%
==========================================
Files 52 52
Lines 2006 1994 -12
==========================================
- Hits 1456 1258 -198
- Misses 550 736 +186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- much more documentation on what this is doing, in README for instance
- explanation of what the different files are
- explanation of how to get "scientific insight" out of these simulations
- in docs/readme/comments explanation of whether there is some global knowledge or instant/telepathic communication between nodes, or whether each node is working just with local information, generally explanation of what is being simulated
- reference to paper related to this
- structuring it similarly to other examples where there is "setup" and then there is "visualization"
- adding an actual doc page, not just readme
- document that this is not the steady steady or that due to triviality this is immediately the steady state, e.g. because it always resets to the same initial configuration
- separate this into something like a setup, an example run that runs only one round, and something that visualizes statistics over many rounds or just repeated simulation over many rounds (specifically, see the simpleswitch example)
Check the readme of these examples for style and content guidelines:
- https://github.com/QuantumSavory/QuantumSavory.jl/tree/master/examples/congestionchain
- https://github.com/QuantumSavory/QuantumSavory.jl/tree/master/examples/simpleswitch
- https://github.com/QuantumSavory/QuantumSavory.jl/tree/master/examples/colorcentermodularcluster
After this is merged, consider making a simple wglmakie demo that we can run live as part of the docs.
procs = [] | ||
for i in 1:S | ||
# entangle sensors with the hub (S+1) | ||
eprot = EntanglerProt(sim, net, i, S + 1; pairstate=noisy_pair, chooseA=1, chooseB=i, success_prob=entanglemnt_success_prob) | ||
@process eprot() | ||
end | ||
@yield timeout(sim, fixed_time) | ||
for p in procs | ||
cancel!(p) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the
procs
is not populated - I think it would be simpler to just do
EntanglerProt(...; success_prob=..., attempt_time=..., attempts=total_time/attempt_time, rounds=1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially add a comment that this works only if you have a large enough switch to not have waiting on a free slot
Let's rename the folder to one of the following:
or something along these lines, just a bit more descriptive. And let's rename the files to be a bit more immediately obvious / standardized, following conventions from the other example folders. |
and add to the tests / examples files to make sure this is always executed during CI |
No description provided.