Skip to content

register slot locks in visualizations #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sagnikpal2004
Copy link

@sagnikpal2004 sagnikpal2004 commented Jun 18, 2025

Added locks drawn over register slots to show that they are locked.
All functionality, including updating the plot with notify works.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • Formatting

registernetplot_example

Notes:

  • The marker is probably not very visible. The color may be changed, or it can be drawn to the side (but drawing to the side causes line segments to be drawn over them)
    Lock to the side (one second change, not committed)
    registernetplot_example

Closes #95

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (fea11cc) to head (e1df176).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ext/QuantumSavoryMakie/QuantumSavoryMakie.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   72.58%   64.65%   -7.93%     
==========================================
  Files          52       52              
  Lines        2006     2006              
==========================================
- Hits         1456     1297     -159     
- Misses        550      709     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sagnikpal2004 sagnikpal2004 marked this pull request as ready for review July 15, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show register lock status in plots of the network
1 participant