-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[FIX AARCH64] Fix Aarch64 architecture runtime issues #10232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
该问题由5b3320624da5149fc21c2d3e1f321d855e3d0dfe引入,导致工具链编译时加上了 -std=gnu99,其他架构是否出问题暂时未知
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Aarch64 runtime issues by removing the unintended addition of the -std=gnu99 flag for the Kernel project during the build process.
- Introduces a new function to strip the -std=gnu99 flag from Compiler Flags
- Registers a pre-building action to apply this change for Aarch64 builds
Comments suppressed due to low confidence (2)
libcpu/aarch64/SConscript:27
- [nitpick] Consider renaming 'del_gnu99' to 'remove_gnu99_flag' for improved clarity.
def del_gnu99():
libcpu/aarch64/SConscript:27
- [nitpick] Adding a brief docstring for this function could help clarify its purpose for future maintainers.
def del_gnu99():
错误截图有吗? |
CI问题已经解决 |
是这里引入的 RT_USING_HOOKLIST with gnu99 |
是不是这类平台不支持gnu99参数? |
在smart上应该是的,所以这个问题是否可以不是这样处理? |
要么这种带有gnu的平台toolchain改成特定的,不要用gcc,改为gccgnu? 或者你们看看有什么建议,mcu平台这些都是要加的,因为很多平台是没有这种参数的。 |
该问题由5b3320624da5149fc21c2d3e1f321d855e3d0dfe引入,导致工具链编译时加上了 -std=gnu99,其他架构是否出问题暂时未知
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up