Skip to content

[FIX AARCH64] Fix Aarch64 architecture runtime issues #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

rcitach
Copy link
Contributor

@rcitach rcitach commented Apr 25, 2025

该问题由5b3320624da5149fc21c2d3e1f321d855e3d0dfe引入,导致工具链编译时加上了 -std=gnu99,其他架构是否出问题暂时未知

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

该问题由5b3320624da5149fc21c2d3e1f321d855e3d0dfe引入,导致工具链编译时加上了 -std=gnu99,其他架构是否出问题暂时未知
@github-actions github-actions bot added Arch: ARM/AArch64 BSP related with arm libcpu labels Apr 25, 2025
@rcitach rcitach changed the title Fix Aarch64 architecture runtime issues [FIX AARCH64] Fix Aarch64 architecture runtime issues Apr 25, 2025
@supperthomas supperthomas requested a review from Copilot April 25, 2025 01:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Aarch64 runtime issues by removing the unintended addition of the -std=gnu99 flag for the Kernel project during the build process.

  • Introduces a new function to strip the -std=gnu99 flag from Compiler Flags
  • Registers a pre-building action to apply this change for Aarch64 builds
Comments suppressed due to low confidence (2)

libcpu/aarch64/SConscript:27

  • [nitpick] Consider renaming 'del_gnu99' to 'remove_gnu99_flag' for improved clarity.
def del_gnu99():

libcpu/aarch64/SConscript:27

  • [nitpick] Adding a brief docstring for this function could help clarify its purpose for future maintainers.
def del_gnu99():

@supperthomas
Copy link
Member

image
你是用的哪一个toolchain?或者哪个bsp?

@supperthomas
Copy link
Member

错误截图有吗?

@rcitach
Copy link
Contributor Author

rcitach commented Apr 25, 2025

错误截图有吗?

CI问题已经解决

@rcitach
Copy link
Contributor Author

rcitach commented Apr 25, 2025

image 你是用的哪一个toolchain?或者哪个bsp?

工具链:https://github.com/RT-Thread/rt-thread/releases/download/v5.2.0/aarch64-linux-musleabi_for_x86_64-pc-linux-gnu_242520-979be38cba.tar.bz2
bsp:rk3500
qemu也会受到影响

@BernardXiong
Copy link
Member

是这里引入的 RT_USING_HOOKLIST with gnu99

@supperthomas
Copy link
Member

是不是这类平台不支持gnu99参数?

@BernardXiong
Copy link
Member

是不是这类平台不支持gnu99参数?

在smart上应该是的,所以这个问题是否可以不是这样处理?

@supperthomas
Copy link
Member

是不是这类平台不支持gnu99参数?

在smart上应该是的,所以这个问题是否可以不是这样处理?

要么这种带有gnu的平台toolchain改成特定的,不要用gcc,改为gccgnu? 或者你们看看有什么建议,mcu平台这些都是要加的,因为很多平台是没有这种参数的。

@Rbb666 Rbb666 merged commit aee8920 into RT-Thread:master Apr 28, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: ARM/AArch64 BSP related with arm libcpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants