Skip to content

Wrong description of the incidence angle #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TobiasSpratte opened this issue Jul 26, 2024 · 1 comment · Fixed by #1583
Closed

Wrong description of the incidence angle #1525

TobiasSpratte opened this issue Jul 26, 2024 · 1 comment · Fixed by #1583
Assignees
@Jun-Jiang-92 @TobiasSpratte
Labels
good first issue

Comments

@TobiasSpratte
Copy link
Contributor

TobiasSpratte commented Jul 26, 2024 •
edited
Loading

In the model AixLib.Utilities.Sources.PrescribedSolarRad, the description of the incidence angle is wrong.
Suggestion:

  • Rename AOI to incAng
  • Change description to: Incidence angle (rad)

image
@TobiasSpratte TobiasSpratte self-assigned this Jul 26, 2024
@Jun-Jiang-92 Jun-Jiang-92 self-assigned this Mar 13, 2025
@Jun-Jiang-92
Copy link
Contributor

@TobiasSpratte Thank you for the finding. I will take this issue.

@Jun-Jiang-92 Jun-Jiang-92 linked a pull request Mar 13, 2025 that will close this issue
1525 wrong description of the incidence angle #1583
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jun-Jiang-92 Jun-Jiang-92

@TobiasSpratte TobiasSpratte

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1525 wrong description of the incidence angle RWTH-EBC/AixLib
2 participants
@Jun-Jiang-92 @TobiasSpratte