-
Notifications
You must be signed in to change notification settings - Fork 81
1525 wrong description of the incidence angle #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1525 wrong description of the incidence angle #1583
Conversation
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
Signed-off-by: Jun Jiang <[email protected]>
@TobiasSpratte Hi, Tobi. Thanks for your review. I have updated the block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thank you!
@larissakuehn Hi, Larissa. This PR seems to request a second reviewer (with write access) for the approvement. Could you please give a review for the changing? |
Changes in this PR:
I
toH
according to new naming space rules, includingI_dir
toHDir
,I_diff
toHDif
,I_gr
toHGrd
AOI
toincAng
One exception is the model
AixLib/ThermalZones/HighOrder/Components/WindowsDoors/BaseClasses/CorrectionSolarGain/CorG_ASHRAE140.mo
, in which internal variablesAOI
andAOI_help
remain unchanged, to keep these internal vars similar to other vars, such asAOR
(angle of refraction).