-
Notifications
You must be signed in to change notification settings - Fork 81
1525 wrong description of the incidence angle #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jun-Jiang-92
merged 8 commits into
main
from
1525-wrong-description-of-the-incidence-angle
May 16, 2025
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b67df1e
Rename solar radiation interfaces
Jun-Jiang-92 5dcc52c
Rename PrescribedSolarRad
Jun-Jiang-92 43831d9
Update version to 2.1.2, add conversion script
Jun-Jiang-92 a8cecdf
Change Imax to H_max in Sunblind models
Jun-Jiang-92 99fa870
Update Imax in wall component
Jun-Jiang-92 73703dc
Add DocStr, convert script
Jun-Jiang-92 175d5b9
Merge branch 'main' into 1525-wrong-description-of-the-incidence-angle
Jun-Jiang-92 1bf4468
CI trigger
Jun-Jiang-92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
AixLib/Resources/Scripts/ConvertAixLib_from_2.1.1_to_2.1.2.mos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
clear | ||
|
||
convertClear(); | ||
|
||
convertElement("AixLib.Utilities.Interfaces.SolarRad_in", "I", "H"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_in", "I_dir", "HDir"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_in", "I_diff", "HDif"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_in", "I_gr", "HGrd"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_in", "AOI", "incAng"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_out", "I", "H"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_out", "I_dir", "HDir"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_out", "I_diff", "HDif"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_out", "I_gr", "HGrd"); | ||
convertElement("AixLib.Utilities.Interfaces.SolarRad_out", "AOI", "incAng"); | ||
convertElement("AixLib.Utilities.Sources.PrescribedSolarRad", "solarRad_out[n]", "solRadOut[n]"); | ||
convertElement("AixLib.Utilities.Sources.PrescribedSolarRad", "I[n]", "H[n]"); | ||
convertElement("AixLib.Utilities.Sources.PrescribedSolarRad", "I_dir[n]", "HDir[n]"); | ||
convertElement("AixLib.Utilities.Sources.PrescribedSolarRad", "I_diff[n]", "HDif[n]"); | ||
convertElement("AixLib.Utilities.Sources.PrescribedSolarRad", "I_gr[n]", "HGrd[n]"); | ||
convertElement("AixLib.Utilities.Sources.PrescribedSolarRad", "AOI[n]", "incAng[n]"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.