1593 add additional heat pump data records #1594
Conversation
…m various manufacturers
| // These tables were created by taking data from graphs from the manufacturer. | ||
| // The temperature intervals are discretized based on the curvature of the curves: | ||
| // finer resolution is used in regions with higher curvature to preserve accuracy. | ||
| // The electrical power (Pel) is calculated using: Pel = Qmax / COP. | ||
| // Some manufacturers don’t provide the same temperature intervals for COP and Qmax, | ||
| // so for Pel, only the common temperature values are used to avoid extrapolation. | ||
| // That’s why the table sizes for Qmax and Pel may be different. |
There was a problem hiding this comment.
Can you make sure each record gets a proper documentation section?
It is easiest to either do it in Dymolas viewer or just directly in text.
An example html structure below. Be sure to include the revision section with your name and the issue number. If at hand, also specify the link to the datasheet and explain the method you used in each file - even though this creates redundancy.
You can highlight variable names like this: <code>PEle</code>.
(Documentation(info="<html>
<p>
Data for large scale (220 kW) water-to-water heat pump from WAMAK.
Nominal pressure losses are the maximal values given in the datasheet,
same for the nominal mass flow rates.
</p>
<h4>References</h4>
<p>
WAMAK, Produktblatt ver. 2023/24.
<a href=\"https://products.wamak.eu/\">
WAMAK Product Sheets Application</a>.
</p>
</html>", revisions="<html>
<ul><li>
<i>November 10, 2023</i> by Fabian Wuellhorst:<br/>
First implementation (see issue <a href=
\"https://github.com/ibpsa/modelica-ibpsa/issues/1576\">#1576</a>)
</li></ul>
</html>"))
There was a problem hiding this comment.
Should I add more to the explanation of the method as I already have in the text above? Should i include that I digitalized the data using https://automeris.io/wpd/? Or what else should I include?
There was a problem hiding this comment.
You may mention that, but I find your description above to be sufficient!
| @@ -0,0 +1,29 @@ | |||
| within AixLib.Fluid.HeatPumps.ModularReversible.Data.TableData2D.EN14511; | |||
| record Average_Heat_Pump "Average Heat Pump" | |||
There was a problem hiding this comment.
Specify how the record was created and what it represents in the doc.
Also, it is mainly residential air-water heat pumps, or? In that case, Maybe AverageAirToWaterResidential as a name?
| extends AixLib.Fluid.HeatPumps.ModularReversible.Data.TableData2D.GenericAirToWater( | ||
| dpEva_nominal=0, | ||
| dpCon_nominal=0, | ||
| tabUppBou=[253.15, 331.15; 316.15, 331.15], |
There was a problem hiding this comment.
Maybe 333.15 is more "average"?
|
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
…he method used for the regression
| </li></ul> | ||
|
|
||
| </html>", info="<html> | ||
| <p>Data for air-to-water heat pump from Remko. These tables are based on digitized data from manufacturer graphs. Temperature intervals are discretized with finer resolution in areas of high curvature to maintain accuracy. Electrical power <span style=\"font-family: Courier New;\">PEle</span> is calculated using the formula: <span style=\"font-family: Courier New;\">PEle</span> = <span style=\"font-family: Courier New;\">Qmax</span> / <span style=\"font-family: Courier New;\">COP</span>. Since manufacturers often provide <span style=\"font-family: Courier New;\">COP</span> and <span style=\"font-family: Courier New;\">Qmax</span> at different temperature points, <span style=\"font-family: Courier New;\">PEle</span> is calculated only at the temperature values common to both datasets to avoid extrapolation. As a result, the <span style=\"font-family: Courier New;\">Qmax</span> and <span style=\"font-family: Courier New;\">PEle</span> tables may differ in size.</p> |
There was a problem hiding this comment.
Can you replace <span style=\"font-family: Courier New;\"> with <code> and </span> with </code>?
|
@Anton2355 There was a HTML error, see: #1595. You can merge this pull request without any review. |
…al-heat-pump-data-records Corrected HTML Code in branch correct_HTML_1593-add-additional-heat-pump-data-records
Added multiple heat pump data records (Q_max, Pel, model name, manufacturer) to EN14511 package for broader applicability. Also included a mean performance curve as a generic model when no specific heat pump is selected.