🛠️ Fix: update value with full path when creating new note in relation field #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating a new note from the RelationEditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Problem
When creating a new note via a Relation column with the bidirectional option enabled, the new note is successfully created in the related database — but the selected option’s value is not updated with the full path to the note. This results in a broken bidirectional relation and an error in the console.
💥 How to Reproduce
Create a Relation column in a DB Folder database with the bidirectional option enabled.
In the table view, go to a cell in that Relation column, type the name of a new note (that doesn't yet exist).
Click Create "note name" when prompted.
Click outside the cell.
Observe:
A console error is thrown.
The new note is created, but the relation option isn't properly updated (value is incomplete), so the bidirectional link fails.
✅ Fix Summary
Modified RelationalServiceInstance.createNoteIntoRelation to return the full path of the newly created note.
In RelationEditor.handleOnChange, during the create-option action, the returned path is now assigned to the correct value field in the newValue array, ensuring the relation is fully functional.
📷 Screenshots (Bug Reproduction)
Screenshot 01 – Relation Settings
Shows the configuration of the relation column with bidirectional enabled.
Screenshot 02 – Creating a New Note in the Related Database
Typing a new note name and selecting Create "note name".
Screenshot 03 – Clicking Away
After clicking away, the note is created but a console error appears. The relation value is not updated correctly.
(Screenshots attached below)
Screenshot 01 - Relation Settings
Screenshot 02 - Creating a new note in the related database
Screenshot 03 - Clicking away
PS: Tis is the first PR i send to a public repo, so let me know anything i could do to make it work for you, i would be very grateful. Thank you for your work making this useful plugin!