Fix: Zoom-in shortcut (Ctrl +) not working, updated accelerator #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schourasia750 Did you solve the issue, why didn't it get merged till now? Like I am actually new to open source and also in college so how do I even solve the issues, will you please contact me. [https://x.com/Rival_o5] |
0xb10ckdev
reviewed
Mar 19, 2025
| @@ -373,7 +373,7 @@ const createViewMenu = createSelector( | |||
| { | |||
| id: 'zoomIn', | |||
| label: t('menus.zoomIn'), | |||
| accelerator: 'CommandOrControl+Plus', | |||
| accelerator: 'CommandOrControl+=', | |||
There was a problem hiding this comment.
It means it should use = instead of +?
|
@Sing-Li could you please review this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2999
-->
Summary
Fixes the issue with the zoom-in shortcut (Ctrl +) not working on the Electron desktop app.
Changes:
Context:
This change ensures that the Ctrl + shortcut works as expected, aligning with the behavior of the zoom-out shortcut and the view toolbar.
Testing:
Verified that the zoom-in shortcut now functions correctly on Windows and macOS.