Allow external nats #151
Open
Allow external nats #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debdutdeb
reviewed
Mar 29, 2025
Comment on lines
299
to
+305
| microservices: | ||
| enabled: false | ||
|
|
||
| nats: | ||
| enabled: true | ||
| existingSecret: '' | ||
|
|
There was a problem hiding this comment.
so the reason I hadn't added this yet was this.
Due to nats deployment being connected to microservices.enabled, we need nats.enabled set to true (as is here) for existing ms deployments to not break on update.
On the other hand, this will cause monolithic deployments to suddenly create nats deployments without needing it.
I guess it's not a big deal - however will need communication so folks can disable this afterwards.
There was a problem hiding this comment.
We can change to
condition: microservices.enabled, nats.enabled
Helm 3 (release 2019) supports this. Basically, we would have to enable both at the same time, and if either of them is false, then it is not deployed (but need more testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new properties:
microservices.nats.enabledthis turns nats deployment off and onmicroservices.nats.existingSecretthis allows you to create a secret holding your nats connectionString inside