Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

SAPUI5 CPQ App #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SAPUI5 CPQ App #2

wants to merge 4 commits into from

Conversation

musaarda
Copy link

Hi this is my pull request for my SAPUI5 CPQ App Showcase.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2020

CLA assistant check
All committers have signed the CLA.

Copy link

@margopolo margopolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the UI5 showcase app.
Please have a look at our comments in your changes for the showcase.json file.
In addition: Also your images look great, can you provide these images without browser window bar and your computer task bar (similar to the images of the other UI5 showases)?

Thanks a lot!
Margot

{
"title":"SAPUI5 CPQ (Configure-Price&Quote)",
"teaser":"",
"author":"Musa Arda",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention here that you are the author of the app - so this meas that this is a private app you wrote for your personal use and you are also the owner of this app? If not, can you share for whom you implemented this app or at least for which industry?

}
],
"website":[
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this step we asked for additional links so people can get some further information of this solution (like the app itself, demo or product description) but you only entered some text without providing any URL. Either remove this entry in your file or add a valid URL, otherwise this will lead to an error in the app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants