Skip to content

Remove outdated Julia version check for v1.7 #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025

Conversation

ChrisRackauckas
Copy link
Member

Summary

  • Removed conditional version check for Julia >= v1.7 in test/forwarddiff_dual_detection.jl
  • Since Julia v1.10 is the current LTS, this check is no longer needed

Changes

The version check was wrapping inference tests that can now run on all supported Julia versions. The conditional block has been removed and the tests now run unconditionally.

Test plan

  • Existing tests should continue to pass
  • No functionality changes, only removal of version gating

🤖 Generated with Claude Code

@ChrisRackauckas ChrisRackauckas force-pushed the remove-outdated-version-checks branch from 3397e12 to 7e5eef5 Compare July 27, 2025 16:04
Since Julia v1.10 is the current minimum supported version (as specified in Project.toml),
the version check for Julia >= v1.7 is always true and can be removed. The code inside
the conditional block is kept since it should always execute.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@ChrisRackauckas ChrisRackauckas force-pushed the remove-outdated-version-checks branch from 7e5eef5 to 7ee8e01 Compare July 27, 2025 16:24
@ChrisRackauckas ChrisRackauckas merged commit 055a366 into master Jul 27, 2025
43 of 47 checks passed
@ChrisRackauckas ChrisRackauckas deleted the remove-outdated-version-checks branch July 27, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant