Skip to content

feat (cleanup forks): initial thoughts #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat (cleanup forks): initial thoughts #168

wants to merge 3 commits into from

Conversation

Dan7-7-7
Copy link
Collaborator

@Dan7-7-7 Dan7-7-7 commented Apr 14, 2025 •
edited
Loading

for #6

@Dan7-7-7 Dan7-7-7 changed the title initial thought feat (cleanup forks): initial thoughts Apr 14, 2025
Dan7-7-7
Dan7-7-7 commented Apr 14, 2025
View reviewed changes
cmd/cleanup/cleanup.go
errorCount++
continue
}
prClosed := pr.Closed == true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only marking them for deletion if their PR is closed - would need to update the log message accordingly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In discussion agreed to check more thoroughly for open PRs (not just from this campaign) using gh pr list --author username --state open

@Dan7-7-7
Copy link
Collaborator Author

Agreed to leave the apply step for a future time and just output the bash command needed to loop over the forks and delete. For the sake of clarity about what is being done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dan7-7-7