Skip to content

Respect multi-line strings while generating CLP files #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sankhesh opened this issue Dec 6, 2012 · 3 comments
Open

Respect multi-line strings while generating CLP files #9

sankhesh opened this issue Dec 6, 2012 · 3 comments
Assignees
@jcfr

Comments

@sankhesh
Copy link
Member

sankhesh commented Dec 6, 2012

See: http://na-mic.org/Mantis/view.php?id=2781
sankhesh added a commit to sankhesh/SlicerExecutionModel that referenced this issue Dec 6, 2012
@sankhesh
Newline characters replaced by line breaks
0b1cf79 
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue Slicer#9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.
@sankhesh sankhesh mentioned this issue Dec 6, 2012
Closed
sankhesh added a commit to sankhesh/SlicerExecutionModel that referenced this issue Dec 6, 2012
@sankhesh
Newline characters replaced by line breaks
1db00cd 
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue Slicer#9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.
sankhesh added a commit to sankhesh/SlicerExecutionModel that referenced this issue Dec 6, 2012
@sankhesh
Newline characters replaced by line breaks
345cb12 
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue Slicer#9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.
sankhesh added a commit to sankhesh/SlicerExecutionModel that referenced this issue Jan 11, 2013
@sankhesh
Newline characters replaced by line breaks
2dd86cd 
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue Slicer#9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.
@hjmjohnson
Copy link
Member

@jcfr JC: Can we make a terminal decision on this? Even if it is just to close the issue?

See: http://na-mic.org/Mantis/view.php?id=2781

@pieper Steve: This would make slicer documentation nicer, but perhaps it is not all that important. We should kill the Slicer mantis issues as well. Even if it is just to state that it won't be addressed.

@pieper
Copy link
Member

pieper commented Apr 24, 2015

I agree it would be great to finalize this one way or another. Since I wasn't involved I don't have an opinion except to agree that nicer documentation would be good if it's not too much work to get there.

@sankhesh
Copy link
Member Author

From what I remember, the original issue was fixed in my commits. However, the changes introduced a single new line. Not sure what would be the current state of the changes.

jcfr pushed a commit that referenced this issue Mar 21, 2018
@sankhesh @jcfr
Newline characters replaced by line breaks
882b86d 
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue #9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.
@jcfr jcfr mentioned this issue Mar 21, 2018
Merged
jcfr pushed a commit that referenced this issue Mar 21, 2018
@sankhesh @jcfr
BUG: Replace newline characters by line breaks
e5e41f5 
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue #9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pieper @jcfr @hjmjohnson @sankhesh