Newline characters replaced by line breaks (rebased) #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QStrings are used for Help and Acknowledgement frame on Slicer module panel. Newline characters are not respected by QString. They need to be line breaks. Fixes issue #9 on the SlicerExecutionModel issue tracker. Fixes issue 2781 on Slicer bug tracker.
jcfr
force-pushed
the
9-respect-multi-line-strings
branch
from
882b86d to
e5e41f5
Compare
jcfr
changed the title
lassoan
reviewed
Mar 22, 2018
There was a problem hiding this comment.
Several CLIs use html formatting and those help texts looks great in Slicer. There is no issue with newlines as <br> works reliably.
I think we should make html the official help format and have a plain text converter for cases when the help needs to be printed on a text-based terminal.
hjmjohnson
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QStrings are used for Help and Acknowledgement frame on Slicer module
panel. Newline characters are not respected by QString. They need to be
line breaks.
Fixes issue #9 on the SlicerExecutionModel issue tracker.
Fixes issue 2781 on Slicer bug tracker.