CHAD-15784 Zigbee: WindowShadePreset capability updates #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 68 files 447 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 3337da1. ♻️ This comment has been updated with latest results. |
|
tuya-zigbee_coverage.xml
zigbee-window-treatment_coverage.xml
zwave-window-treatment_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3337da1 |
inasail
reviewed
Jul 25, 2025
| @@ -15,6 +15,23 @@ | |||
| local capabilities = require "st.capabilities" | |||
| local ZigbeeDriver = require "st.zigbee" | |||
| local defaults = require "st.zigbee.defaults" | |||
| local window_preset_defaults = require "st.zigbee.defaults.windowShadePreset_defaults" | |||
|
|
|||
| local function init_handler(self, device) | |||
There was a problem hiding this comment.
Like I mentioned in the CHAD-15784, we need this.
device:emit_event(capabilities.windowShadePreset.supportedCommands({"presetPosition", "setPresetPosition"}, { visibility = { displayed = false }})) in init handler.
There was a problem hiding this comment.
And also we need to add these codes in
-
vimar (init overrided)
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zigbee-window-treatment/src/vimar/init.lua#L133 -
This is a different driver
https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/Unofficial/tuya-zigbee/src/curtain/init.lua#L132
PS: If you hesitate to manage the Unofficial driver, I can request SRCN to do this.
inasail
reviewed
Jul 25, 2025
|
|
||
| local function added_handler(self, device) | ||
| device:emit_event(capabilities.windowShade.supportedWindowShadeCommands({"open", "close", "pause"}, { visibility = { displayed = false }})) | ||
| device:emit_event(capabilities.windowShadePreset.supportedCommands({"presetPosition", "setPresetPosition"}, { visibility = { displayed = false }})) | ||
| device:emit_event(capabilities.windowShadePreset.position(window_preset_defaults.PRESET_LEVEL, { visibility = {displayed = false}})) |
There was a problem hiding this comment.
I think 'windowShadePreset.position' should only be emitted when there is no latest value, because the added() handler is called in the case of a hub switch-over.
The same goes for Tuya curtain in Unofficial driver.
inasail
approved these changes
Jul 28, 2025
|
Duplicate profile check: Passed - no duplicate profiles detected. |
wkhenon
approved these changes
Aug 1, 2025
nickolas-deboom
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.