Skip to content

CHAD-15785 Z-Wave: WindowShadePreset capability updates #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CHAD-15785 Z-Wave: WindowShadePreset capability updates #2292

wants to merge 2 commits into from

Conversation

greens
Copy link
Contributor

@greens greens commented Jul 29, 2025

No description provided.

@github-actions GitHub Actions
Copy link

Duplicate profile check: Warning - duplicate profiles detected.
window-treatment-preset-reverse.yml == base-window-treatment.yml

@github-actions GitHub Actions
Copy link

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/Q1jP0aDVnVjL

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2025 •
edited
Loading

Test Results

   68 files    447 suites   0s ⏱️
2 309 tests 2 255 ✅ 0 💤 0 ❌ 54 🔥
3 894 runs  3 831 ✅ 0 💤 0 ❌ 63 🔥

For more details on these errors, see this check.

Results for commit af50d78.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2025 •
edited
Loading

File Coverage
All files 67% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/preferences.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/window_preset_defaults.lua 37% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-window-treatment/src/init.lua 47% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against af50d78

inasail
inasail reviewed Jul 29, 2025
View reviewed changes
drivers/SmartThings/zwave-window-treatment/src/springs-window-fashion-shade/init.lua
@@ -37,6 +37,16 @@ local function can_handle_springs_window_fashion_shade(opts, driver, device, ...
return false
end

local function init_handler(self, device)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sub driver doesn't need to be modified because it doesn't have any UI(like preference setting) related with 'presetPosition'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This device allows the user to set a preset position with the included remote that can then be recalled via a MultiLevelSwitch:0xFF command. I did this to be certain that setPresetPosition is not supported, as it would be if I did not override the base driver's init handler.

inasail
inasail approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@inasail inasail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkhenon wkhenon wkhenon approved these changes

@nickolas-deboom nickolas-deboom Awaiting requested review from nickolas-deboom

+1 more reviewer

@inasail inasail inasail approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greens @inasail @wkhenon