fix: spurious oauth token requests when we already have a valid token. #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dljsjr
force-pushed
the
fix/sonos-spurious-oauth-requests
branch
from
150bf68 to
658dffa
Compare
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0516d3c |
Test Results 68 files 447 suites 0s ⏱️ Results for commit 0516d3c. ♻️ This comment has been updated with latest results. |
varzac
reviewed
Jul 30, 2025
7 tasks
dljsjr
force-pushed
the
fix/sonos-spurious-oauth-requests
branch
from
658dffa to
0516d3c
Compare
cjswedes
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
There were a handful of situations where the driver was making a request to the cloud for a new copy of the user's Sonos OAuth token, even if the token was cached on the hub and had not yet expired. This attempts to address that.
Summary of Completed Tests
Tested on my personal setup by overriding the driver files directly. Will need to be regression tested by internal QA once this lands on Alpha; the OAuth stuff precludes this from being tested using the PR channel invite.