Skip to content

Added several flags #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added several flags #3

wants to merge 1 commit into from

Conversation

LuxionUO
Copy link
Contributor

Added flags for:

  • CChar: canflags
  • CRegion: regionflags
  • CObjBase: attr
  • CObjBase: damflags
  • MySQL: Calls & Functions

@LuxionUO LuxionUO mentioned this pull request Jul 24, 2023
Open
@cbnolok
Copy link
Contributor

cbnolok commented Jul 26, 2023

I have few suggestions:

  • could you reuse the prefixes in the regexs? Like (statf_(dead|stone)), it makes a regex faster
  • could you order alphabetically the words in the regex?
  • could you rename mdb to sqlite?

What do you think?

@LuxionUO
Copy link
Contributor Author

Yes sounds reasonable. I will make this change once I am back in London.

@cbnolok cbnolok marked this pull request as draft October 19, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LuxionUO @cbnolok