Skip to content

[BugFix] Deletion task failed when using datetime as a deletion predicate #58933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025

Conversation

sevev
Copy link
Contributor

@sevev sevev commented May 13, 2025

Why I'm doing:

Since version 3.3.5, the datetime type supports millisecond precision, but deletion operations fail when using datetime values with millisecond precision as deletion predicates.
The reason is that BE doesn't support millisecond precision when validating datetime legality.

What I'm doing:

BE support millisecond precision for datetime legality

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@sevev sevev requested a review from a team as a code owner May 13, 2025 10:59
Signed-off-by: sevev <[email protected]>
wyb
wyb previously approved these changes May 16, 2025
Signed-off-by: sevev <[email protected]>
@sevev sevev dismissed stale reviews from silverbullet233 and wyb via 82fb72a May 19, 2025 05:51
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@wyb wyb enabled auto-merge (squash) May 19, 2025 09:27
@wyb wyb merged commit ff9d27f into StarRocks:main May 19, 2025
51 checks passed
Copy link

@Mergifyio backport branch-3.5

Copy link

@Mergifyio backport branch-3.4

Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 19, 2025
Copy link
Contributor

mergify bot commented May 19, 2025

backport branch-3.5

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 19, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 19, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 19, 2025
mergify bot pushed a commit that referenced this pull request May 19, 2025
mergify bot pushed a commit that referenced this pull request May 19, 2025
wanpengfei-git pushed a commit that referenced this pull request May 19, 2025
wanpengfei-git pushed a commit that referenced this pull request May 19, 2025
wanpengfei-git pushed a commit that referenced this pull request May 20, 2025
Mesut-Doner pushed a commit to Mesut-Doner/starrocks that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants