Skip to content

[BugFix] Fail to build MaterializedView relationship when do reload after FE image loaded #58990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[BugFix] Fail to build MaterializedView relationship when do reload after FE image loaded #58990

merged 1 commit into from
May 15, 2025

Conversation

wxl24life
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@wxl24life wxl24life requested a review from a team as a code owner May 15, 2025 04:03
@github-actions github-actions bot added the 3.5 label May 15, 2025
@wxl24life wxl24life changed the title [BugFix] Fail to build MaterializedView related MVs when reloading after FE image load [BugFix] Fail to build MaterializedView relationship when do reload after FE image loaded May 15, 2025
LiShuMing
LiShuMing reviewed May 15, 2025
View reviewed changes
@wxl24life wxl24life force-pushed the xiaolong/github_fix_mv_reload_post_image branch 2 times, most recently from da13321 to d687359 Compare May 15, 2025 07:41
@wxl24life wxl24life force-pushed the xiaolong/github_fix_mv_reload_post_image branch from d687359 to 3241409 Compare May 15, 2025 07:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/MaterializedView.java 6 6 100.00% []
🔵 com/starrocks/common/Config.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing merged commit 89e6352 into StarRocks:main May 15, 2025
58 of 59 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.5 label May 15, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented May 15, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 15, 2025
@wxl24life @mergify
[BugFix] Fail to build MaterializedView relationship when do reload a…
3360099 
…fter FE image loaded (#58990)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit 89e6352)
@mergify mergify bot mentioned this pull request May 15, 2025
Merged
24 tasks
@andyziye
Copy link
Collaborator

@Mergifyio backport branch-3.5.0-rc01

@mergify Mergify
Copy link
Contributor

mergify bot commented May 15, 2025 •
edited
Loading

backport branch-3.5.0-rc01

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 15, 2025
@wxl24life @mergify
[BugFix] Fail to build MaterializedView relationship when do reload a…
5a86604 
…fter FE image loaded (#58990)

Signed-off-by: drake_wang <[email protected]>
(cherry picked from commit 89e6352)
@mergify mergify bot mentioned this pull request May 15, 2025
Merged
24 tasks
wanpengfei-git pushed a commit that referenced this pull request May 15, 2025
@mergify @wxl24life
[BugFix] Fail to build MaterializedView relationship when do reload a…
6ee4d14 
…fter FE image loaded (backport #58990) (#59008)

Signed-off-by: drake_wang <[email protected]>
Co-authored-by: Drake Wang <[email protected]>
andyziye pushed a commit that referenced this pull request May 15, 2025
@mergify @wxl24life
[BugFix] Fail to build MaterializedView relationship when do reload a…
461882e 
…fter FE image loaded (backport #58990) (#59014)

Signed-off-by: drake_wang <[email protected]>
Co-authored-by: Drake Wang <[email protected]>
Mesut-Doner pushed a commit to Mesut-Doner/starrocks that referenced this pull request May 21, 2025
@wxl24life @Mesut-Doner
[BugFix] Fail to build MaterializedView relationship when do reload a…
ac4ae9f 
…fter FE image loaded (StarRocks#58990)

Signed-off-by: drake_wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiShuMing LiShuMing LiShuMing approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@wxl24life wxl24life

Labels
3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wxl24life @andyziye @LiShuMing @gengjun-git