Skip to content

[Enhancement] MV support self-union-join #58996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

[Enhancement] MV support self-union-join #58996

merged 2 commits into from
May 16, 2025

Conversation

crossoverJie
Copy link
Contributor

@crossoverJie crossoverJie commented May 15, 2025 •
edited
Loading

Why I'm doing:

Refer to this #58919 ; the current MV does not support self-join.

What I'm doing:

When the join table is the same table, continue executing the com.starrocks.scheduler.mv.MVPCTRefreshPlanBuilder#pushDownPartitionPredicates function.

Fixes #58919

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1

@crossoverJie
[Enhancement] Improve partition predicate pushdown logic and add test…
a5e12de 
… for UNION on self-referential materialized views

Signed-off-by: crossoverJie <[email protected]>
@crossoverJie
deal union relation
0118c27 
Signed-off-by: crossoverJie <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@crossoverJie crossoverJie changed the title [Enhancement] MV support self-join [Enhancement] MV support self-union-join May 15, 2025
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/mv/MVPCTRefreshPlanBuilder.java 3 3 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@LiShuMing LiShuMing merged commit 6f0d3d5 into StarRocks:main May 16, 2025
71 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 16, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 16, 2025
@crossoverJie @mergify
[Enhancement] MV support self-union-join (#58996)
d6d2d6e 
Signed-off-by: crossoverJie <[email protected]>
(cherry picked from commit 6f0d3d5)
@mergify mergify bot mentioned this pull request May 16, 2025
Open
24 tasks
mergify bot pushed a commit that referenced this pull request May 16, 2025
@crossoverJie @mergify
[Enhancement] MV support self-union-join (#58996)
013a0e6 
Signed-off-by: crossoverJie <[email protected]>
(cherry picked from commit 6f0d3d5)
@mergify mergify bot mentioned this pull request May 16, 2025
Merged
24 tasks
mergify bot pushed a commit that referenced this pull request May 16, 2025
@crossoverJie @mergify
[Enhancement] MV support self-union-join (#58996)
1f6d8d3 
Signed-off-by: crossoverJie <[email protected]>
(cherry picked from commit 6f0d3d5)
@mergify mergify bot mentioned this pull request May 16, 2025
Merged
24 tasks
@github-actions github-actions bot added the 3.3 label May 16, 2025
wanpengfei-git pushed a commit that referenced this pull request May 19, 2025
@mergify @crossoverJie
[Enhancement] MV support self-union-join (backport #58996) (#59026)
efa3725 
Signed-off-by: crossoverJie <[email protected]>
Co-authored-by: crossoverJie <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 19, 2025
@mergify @crossoverJie
[Enhancement] MV support self-union-join (backport #58996) (#59027)
34affa3 
Signed-off-by: crossoverJie <[email protected]>
Co-authored-by: crossoverJie <[email protected]>
Mesut-Doner pushed a commit to Mesut-Doner/starrocks that referenced this pull request May 21, 2025
@crossoverJie @Mesut-Doner
[Enhancement] MV support self-union-join (StarRocks#58996)
628127a 
Signed-off-by: crossoverJie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

Assignees

@crossoverJie crossoverJie

Labels
3.3 3.4-merged 3.4 3.5-merged 3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a MV uses a union to join with itself, the MV cannot be refreshed.
3 participants
@crossoverJie @satanson @LiShuMing