-
-
Notifications
You must be signed in to change notification settings - Fork 912
Skyculture "Ruanui sky : Tahiti and Society islands" #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Since version 25.1 we have a new format for storing the data of sky cultures and conversion tool from old format to the new one. At the moment I have a few questions:
|
Hello Alex-w, Thank you for your reply ! Where can I find the conversion tool ? Here are the anwsers :
Thank you for your help ! |
Please see User Guide chapter 9. |
I updated the file for the planets names, using the user guide. For instance Saturn look now like this : But I fail to find a way to do the same with stars. According to the user guide, the code for a star should look like this : Where can I put the english translation for the native name of a star ? I agree it would be very interesting as the translation is often a complete sentence. Thanks a lot for your help ! Thibaud |
Please update to current version 25.1 and then use the User Guide that comes with version 25.1, chapter 9, to find all instructions, and take skycultures that come with 25.1 for examples. Convert your work with the converter that comes with version 25.1, then continue work on the converted result. Note that 25.1 does not show all cultural names on screen yet, but 25.2 (scheduled for June) will. |
Thank you qzotti, i'm working on it |
better examples are the Siberian, Chinese and Greek (Almagest) - I think, they are the most complete (in terms of foreign characters, translations etc.) Good luck! |
@ThibaudGS any updates? Are you planning completion ready for 25.2 or later? To see most new settings affecting name labelling, use a https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot |
Hi Gzotti ! sorry for the delay. I follow the guide 25.1 and I have a few new files to create, using Chinese skyculture as an example. I'll do my best but I don't think I can deliver for the 25.2 release. What is the deadline ? Thank you again for your help ! |
If you can provide at least a first version by Friday, it could go into master, let translators do their work for a week, and be in 25.2. Extensions are possible later. If it's not meaningful yet, aim for 25.3. |
Thank you again gzotti, I think a first version by friday is possible ! |
Hi ! I finished the corrections ! Both files "index.json" and "description.md" are working on my computer (Stellarium 25.1). Both illustrations are in the "illustrations" folder, and it's working. |
It seems this is based on a very old (pre-25) master. And it has not been developed in a separate branch as we recommend in the wiki. I cannot review this by just checking out and compiling, as it uses the old skyculture classes. I could messily copy files around, but we want to keep a structure. @10110111, @alex-w what is the best command sequence for bringing this on top of current stellarium/master? I am not sure, it may be enough if ThibaudGS states on his system, in ThibaudGS/master: git pull --rebase (this assumes his master just derives from stellarium's master. ) Or maybe in the git website here, locate the "Update branch" button and select "Update with rebase"? |
Ok, thanks. I wait for the instructions. |
The branch can be simply rebased. Then the After this Maybe something else, but I didn't check further. |
I tried to understand how to rebased the branch, but it is my first time in Github and I don't understand... |
Ok, I deleted the files |
There's a small typo in one of the constellations. Line 70 of "Vortex ocean in wich to lose crime" |
Yes, there are a few such minor issues. Instead of describing each in long sentences, I can fix them in a post-merge cleanup. Or if you want, you can send a pull request. @ThibaudGS I wonder, are the figures of Orion (with shield and raised club), Gemini, Auriga, Perseus, Hydra, Crater, Corvus, Pisces, Cygnus really seen like "in the West", just with different names (which mostly don't seem to fit to those figures)? It looks strange to me. Other than that, technically it's OK now for me. @alex-w ? @sushoff ? |
Western stick figures for the local constellations looks strange for me too. Is it western influence or unknown stick figures for these constellations? |
I corrected the Typo "wich" in index. |
The only consensus find to diverge from western figures was : "Hiro's kite" and "Maui's hook" (for the Scorpio) and the "Cluster of four" (for the Crux) |
So, OK for me, but with typofixes after merge... |
Is it possible to create stick figures in the area that resemble the term to which the Tahiti name refers? I'm asking because stick figures are not historical: no other culture but the Chinese one had stick figures. Also the European/ American and all other stick figures have been invented in the 20th century. Thus, I consider it justified to create historical stick figures in the way that they resemble the shape - e.g. check the "Greek (Almagest) culture for reference: there are no stick figures in the historical Greek culture and specifically no ones in the Almagest or illustrated copies of it - for the whole two millennia of its tradition. The stick figures in Stellarium, thus, resemble the shape of the constellation in antiquity, conciously and carefully reconstructing what the star designations describe (e.g. "the eye of someone" coordinates x,y) Could you try to do sth.. similar, so that your stick figures fit the Tahiti name? Please! :-) |
I can try to do it. Unfortunately some of the tahitian names are difficult to illustrate, like "Forest of parental yearnings". Maybe I can at least try to make it look different from the western stick figure (in particular for constellations like Orion which are very recognizable). What is the deadline for this work ?... I guess quickly so it can fit in the 25.2 |
I changed slightly the stick figures in index file. Mostly to make it different from the western visual, in a very minimalist way. A more elaborate work would need discussion with my working group which may take a long time. The next step for this skyculture will be to find illustrations for all the constellations, with the help of more people from tahitian community. I'm sure that the stick figures will be more approprietly modified when this (exciting !) work will be done, for a future extension of Stellarium. |
Hi ! What should I do now ? Are we still in time for the 25.2 ? Thanks for your help ! :) |
Thank you !! Mauruuru roa ! Now that the branch is merged, do I have something to do ? |
A few of the names are hard to comprehend and translate. Is the "Parent eater of rock" a fish (Loup de Mer)? Is it then just a "parent (older specimen) of the fish species 'Loup de Mer'"? If this item has any significance in Ruanui culture, the description.md would be the place to write about it. (The same applies to actually all constellations. A minimum of indigenous stories around the constellations would increase the value of this contribution. ) |
Description
A new skyculture was added "Ruanui sky : Tahitit and Society islands".
This skyculture contains stars and constellations used in traditional polynesian astronomy in Society Islands (Tahiti, Bora bora...).
The main book reference we used was "Ancient Tahiti", therefore these stars are mainly the stars taught by Ruanui, an old lady from Bora bora whose knowledge was translated in the Book "Ancient Tahiti" by Teuira Henry.
This skyculture was missing, and our working group is proud to add this relevant addition to the Stellarium software, so that the polynesian population, but also a larger audience, can access this traditional knowledge.
The working group was composed of tahitian experts in polynesian astronomy (Christine Briant, Libor Prokop, Regis Plichart) and cultural tahitian associations ("Fa'afaite i te ao maohi", "Te Fare Hiroa no Vavau").
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
This code has been tested on a computer version of Stellarium 24.1
We tested : star names, constellations names, constellation ships, constellation illustrations (with seasonal rules), planets names
Test Configuration:
Operating system: <Name, version number>
Windows 11
Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>
Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz 1.50 GHz
NVidia GeForce
Checklist:
My code follows the code style of this project.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (header file)
I have updated the respective chapter in the Stellarium User Guide
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules