Bump soto-s3-file-transfer to 2.x #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Mar 21, 2025
| defer { | ||
| try? s3FileTransfer.syncShutdown() | ||
| } | ||
| let s3FileTransfer = S3FileTransferManager(s3: s3, configuration: .init(maxConcurrentTasks: 60)) |
There was a problem hiding this comment.
@adam-fowler it looks like there were some API changes around thread provider and shutdown - do these changes make sense to you? I'm guessing the S3FileTransferManager taps into the underlying S3 client now?
There was a problem hiding this comment.
Changes look good as far as I can tell
daveverwer
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix SwiftPackageIndex/SwiftPackageIndex-Server#3739 (comment)
Error is reproducible with our test file: https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/$252Faws$252Flambda$252FDocUploaderLambda-Test-UploadFunction-A0zLSxC2sCV5/log-events/2025$252F03$252F21$252F$255B$2524LATEST$255D3d79f7ef55144aaa92632e8ee812fddf
and fixed with the new version:
https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/$252Faws$252Flambda$252FDocUploaderLambda-Test-UploadFunction-A0zLSxC2sCV5/log-events/2025$252F03$252F21$252F$255B$2524LATEST$255D2397d76ab2974cdf942db0b9562ed262