Skip to content

fixed SV bbox bus msb; black formatting #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

fixed SV bbox bus msb; black formatting #9

merged 1 commit into from
Jun 9, 2025

Conversation

jeffng-or
Copy link
Collaborator

@jeffng-or jeffng-or commented Jun 6, 2025 •
edited
Loading

  • rd_out bus msb was incorrect
  • Added reg test to check bus msb against expectations
  • Some code re-formatting per Black
  • Fixed y_step snapping issue found in private PDK
  • Added unit test for y_step calculation

@jeffng-or
fixed SV bbox bus msb; black formatting
5484281 
fixed snapping which was creating off-grid pins
added calc_y_step unit test + black formatting

Signed-off-by: Jeff Ng <[email protected]>
@jeffng-or jeffng-or force-pushed the sv-bbox-bus-width branch from ffc74c6 to 5484281 Compare June 9, 2025 15:04
@jeffng-or jeffng-or requested a review from maliberty June 9, 2025 15:05
@maliberty maliberty merged commit 9c04e62 into The-OpenROAD-Project:main Jun 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffng-or @maliberty