Skip to content

Fix yaml XP rewards for China Hacker #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DevGeniusCode
Copy link
Collaborator

No description provided.

@xezon xezon added the Documentation Is documentation or complementary resource label Mar 19, 2025
@xezon
Copy link
Contributor

xezon commented Mar 19, 2025

Nice. Can you bundle more doc/script fixes into your change? I want to avoid many small changes doing small fixups for the similar kinds of things.

@DevGeniusCode
Copy link
Collaborator Author

DevGeniusCode commented Mar 22, 2025

Nice. Can you bundle more doc/script fixes into your change? I want to avoid many small changes doing small fixups for the similar kinds of things.

I have added updates in the links above.

I think it's now possible to create two merges, one commit for mod Builder, and a second commit for yaml file fixes

@xezon
Copy link
Contributor

xezon commented Mar 25, 2025

What do you mean with "commit for Mod Builder" ? I think all the changes linked here can be merged into one change for fixing Documentation.

@DevGeniusCode
Copy link
Collaborator Author

What do you mean with "commit for Mod Builder" ? I think all the changes linked here can be merged into one change for fixing Documentation.

I mean this 3 PRs from @Polypheides , I think they are not related to yaml files
#2717, #2715, #2688

image

@xezon
Copy link
Contributor

xezon commented Mar 25, 2025

Ok. But #2646 is.

I would like to see #2688 cramped into another change. We should not make many one liner commits, because it will pollute the commit history.

@Polypheides
Copy link
Contributor

Maybe make this pull request a general "Fix for various Documents" bundle.

@DevGeniusCode
Copy link
Collaborator Author

Can close the current PR, the commit for the current PR has been moved to #2646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Is documentation or complementary resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants