Skip to content

Fix ukrainian translation of SIDE:ChinaInfantryGeneral and GUI:Multiplayer #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix ukrainian translation of SIDE:ChinaInfantryGeneral and GUI:Multiplayer #2735

wants to merge 5 commits into from

Conversation

Windstalker
Copy link
Contributor

@Windstalker Windstalker commented Mar 25, 2025 •
edited
Loading

  • Fix ukrainian translation of SIDE:ChinaInfantryGeneral to be consistent with other two China generals translations
  • Fix ukrainian translation for GUI:Multiplayer

Additional changes:

  • Add edit-3 version of ukrainian generals.str

@Windstalker
Fix UA translation of SIDE:ChinaInfantryGeneral
0f5d820 
Add edit-3 version of ukrainian generals.str
@dmgreeny
Copy link
Collaborator

Good change, but this file is broken Patch104pZH/Design/Scripts/str/data/ukrainian_zh_by_yarpik_windstalker_edit_3/generals.str

@dmgreeny dmgreeny added Text Is text, string, localization related Minor Severity: Minor < Major < Critical < Blocker labels Mar 25, 2025
@Polypheides
Copy link
Contributor

Polypheides commented Mar 26, 2025 •
edited
Loading

Good change, but this file is broken

the edit 2 is also looking strange ending on CONTROLBAR:TooltipFireLaserCannon

@Windstalker are these progress files or is your source file outdated?

It should end on OBJECT:Militia

@Windstalker
Copy link
Contributor Author

Windstalker commented Mar 26, 2025 •
edited
Loading

Good change, but this file is broken

the edit 2 is also looking strange ending on CONTROLBAR:TooltipFireLaserCannon

@Windstalker are these progress files or is your source file outdated?

It should end on OBJECT:Militia

Then I will just revert this edit_3 back and wait until gametextcompiler will support Ukrainian to compile a fresh correct generals.str

@Polypheides
Copy link
Contributor

Polypheides commented Mar 26, 2025 •
edited
Loading

Then I will just revert this edit_3 back and wait until gametextcompiler will support Ukrainian to compile a fresh correct generals.str

On Discord https://discord.com/channels/951133504605917224/1352632758920548404/1354246884373434508

@Windstalker
Copy link
Contributor Author

On Discord https://discord.com/channels/951133504605917224/1352632758920548404/1354246884373434508

What do I supposed to see? It seems that I lack some role on this server.

@Polypheides
Copy link
Contributor

What do I supposed to see? It seems that I lack some role on this server.

yes ask for dev roll tell them who you are and what you do, translations for Ukrainian etc and they add you that link is a download for gametextcompiler supporting new languages. :)

@Windstalker Windstalker changed the title Fix UA translation of SIDE:ChinaInfantryGeneral Fix ukrainian translation of SIDE:ChinaInfantryGeneral and GUI:Multiplayer Mar 26, 2025
@Windstalker
Copy link
Contributor Author

Updated edit-3, added fix for GUI:Multiplayer

@Windstalker Windstalker requested a review from xezon March 28, 2025 07:18
@Windstalker Windstalker requested a review from dmgreeny April 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon Awaiting requested review from xezon

@dmgreeny dmgreeny Awaiting requested review from dmgreeny

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Windstalker @dmgreeny @Polypheides @xezon