Ability to change the behavior of the RouteClaimsRequirement check #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
@bogd4nov1van We have 2 ways with this PR:
So, I am not a fan to go with 1st way. This PR has "typofix" commits. It is bad to mix such kind of commits (text formatting issues) because it is hard to review implemented logic (real code). So, it is hard to review your current PR. Let's go with the 2nd way. Do not forget to pull latest top commits from base branch! So, you have to put your commits on the top of base HEAD commit! Do you agree? Sorry, I'm going to mark this PR as draft because of merge conflicts! |
raman-m
added
invalid
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution for this issue #746