Skip to content

fix: do not ignore host when connect tls #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

warjiang
Copy link

@warjiang warjiang commented Mar 2, 2025

for bilateral tls verification, the host should not be ignored, if the host field be ignored, it will be set to localhost automatically. But the default host(localhost) is not correspoding to tls certificate.

for kubernetes it will use bilateral tls verification, for tls website it will use single tls verification. And I've already tested the traditional tls web site and the communication of kuberntes apiserver two traditional cases, it all works ok.

relasted issues: #365

Copy link

changeset-bot bot commented Mar 2, 2025

⚠️ No Changeset found

Latest commit: e7fec9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Mar 22, 2025 2:35pm

@warjiang
Copy link
Author

warjiang commented Mar 2, 2025

how to work with changeset @TooTallNate

@warjiang
Copy link
Author

@lukekarrys should I reformat the code for passing CI, any local format instructions for me?

@warjiang
Copy link
Author

@lukekarrys should I reformat the code for passing CI, any local format instructions for me?

@lukekarrys Sorry, it's not the problem of lint, it's the problem of format task. I've already fix the format problem, could you help me to re-trigger the Node CI action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant