Skip to content

Resolve clippy::fallible_impl_from #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jhpratt
Copy link
Collaborator

@jhpratt jhpratt commented May 9, 2025

Type of change

clippy

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved


nativelink-util/src/action_messages.rs line 904 at r1 (raw file):

                .into_iter()
                .map(TryInto::try_into)
                .collect::<Result<_, _>>()?,

nit: The ::<Result<_,_>> part might be unnecessary.

Copy link
Contributor

@jaroeichler jaroeichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 2 of 2 LGTMs obtained, and all files reviewed, and 2 discussions need to be resolved


nativelink-util/src/action_messages.rs line 539 at r1 (raw file):

            }
            NameOrPath::Name(_) => Err(make_input_err!(
                "Cannot return a SymlinkInfo that uses a NameOrPath::Path(), it must be a NameOrPath::Name()"

nit: Switch Path() and Name() in the error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants