Add retries for json parsing error

app/models/types/errors.go

@@ -11,3 +11,5 @@ var ErrInvalidStory = errors.New("invalid story")
 var ErrInvalidStoryStatusTransition = errors.New("invalid story status transition")
 
 var ErrAnotherStoryAlreadyInProgress = errors.New("another story already in progress")
+
+var ErrJsonParsingRetriesExceeded = errors.New("json parsing retries exceeded")

app/prompts/nextjs/ai_frontend_developer_edit_code_retry.txt

@@ -0,0 +1,73 @@
+You are tasked with updating the frontend code to resolve build errors. You will be given information about a specific file, the error description, the current code, and the project's directory structure. Your job is to propose a solution by either editing existing code or inserting new code.
+
+Here's the file you need to work on:
+<file_name>
+{{FILE_NAME}}
+</file_name>
+
+The build error description is as follows:
+<error_description>
+{{ERROR_DESCRIPTION}}
+</error_description>
+
+Here's the current code in the file:
+<current_code>
+{{CURRENT_CODE}}
+</current_code>
+
+The directory structure of the project is:
+<directory_structure>
+{{DIRECTORY_STRUCTURE}}
+</directory_structure>
+
+Based on the error description and the current code, you must choose ONE of the following actions:
+
+1. Edit code:
+   Replace the code in the given file path from `start_line` to `end_line` with `new_code`.
+
+2. Add code:
+   Insert the code in the given file path below the `line_number`.
+
+Provide your response in JSON format, following one of these structures:
+
+For editing code:
+{
+    "type": "edit",
+    "start_line": Starting Line number,
+    "end_line": Ending Line number,
+    "new_code": Code snippet
+}
+
+For inserting code:
+{
+    "type": "insert",
+    "line_number": Line number,
+    "new_code": Code snippet
+}
+
+Guidelines for code editing and inserting:
+- When editing, provide the code snippet from several lines before and after the actual edit to ensure proper context. Aim to edit complete sections of the code, covering at least 20-30 lines.
+- If multiple edits are needed, choose line numbers that cover all necessary changes. In extreme cases, you may edit the entire file by setting start_line = 1 and end_line = last line of code.
+- Do not include ```json and ``` in your response.
+- Ensure that the proposed code is syntactically correct.
+- Beware of any unescaped single quotes (') in the JSX code. Do not have unescaped single quotes in the code, use &apos; or &quot; or other appropriate methods instead.
+
+Remember to provide only one edit or insert at a time. Your primary goal is to resolve the build error while maintaining the integrity of the code.
+
+Present your solution in the JSON format described above, without any additional explanation or commentary.
+
+The previous response was not valid JSON. Please provide the edit instructions in the specified JSON format. Here is the format:
+For editing code:
+{
+    "type": "edit",
+    "start_line": Starting Line number,
+    "end_line": Ending Line number,
+    "new_code": Code snippet
+}
+
+For inserting code:
+{
+    "type": "insert",
+    "line_number": Line number,
+    "new_code": Code snippet
+}

app/prompts/nextjs/next_js_build_checker_retry.txt

@@ -0,0 +1,102 @@
+You are an AI assistant tasked with analyzing the build logs of a website's frontend and determining if the build was successful. If not, you'll need to suggest an action to resolve the issue. You'll be provided with the following information:
+
+<build_logs>
+{{BUILD_LOGS}}
+</build_logs>
+
+<directory_structure>
+{{DIRECTORY_STRUCTURE}}
+</directory_structure>
+
+Your task is to:
+1. Analyze the build logs carefully.
+2. Determine if the build was successful or not.
+3. If the build was not successful, suggest one of the following actions:
+   a. Create a new file
+   b. Edit an existing file
+
+To determine if the build was successful:
+- Look for phrases like "Build successful", "Build completed", or similar indications of success.
+- Check for error messages, warnings, or failed steps in the build process.
+- Pay attention to the final lines of the build logs, as they often contain the build status.
+
+If the build was not successful:
+1. Identify the root cause of the failure based on the error messages in the build logs.
+2. Consider the logs and directory structure when suggesting a solution.
+3. Choose the most appropriate action (create, or edit) to resolve the issue.
+4. Provide detailed information about the action, including file paths (relative to the root directory) or terminal commands.
+5. Include line numbers from the build logs in your description if available.
+
+Provide your response in the following JSON format:
+
+For a successful build:
+{
+    "build_successful": "Yes"
+}
+
+For an unsuccessful build:
+{
+    "build_successful": "No",
+    "action": {
+        "type": "create|edit",
+        "file_path": "path/to/file",
+        "description": "Detailed description of the action and why it's needed"
+    }
+}
+Examples to clarify:
+{
+    "build_successful": "No",
+    "action": {
+        "type": "create",
+        "file_path": "path/to/file",
+        "description": "Detailed description of the action and why it's needed"
+    }
+}
+
+{
+    "build_successful": "No",
+    "action": {
+        "type": "edit",
+        "file_path": "path/to/file",
+        "description": "Detailed description of the action and why it's needed"
+    }
+}
+
+
+Remember to analyze the build logs thoroughly and provide a clear, concise explanation of the issue and the proposed solution in the "description" field. Do not include the ```json and ``` markers in your response.
+
+The previous response was not valid JSON. Please provide the edit instructions in the specified JSON format. Here is the format:
+Provide your response in the following JSON format:
+
+For a successful build:
+{
+    "build_successful": "Yes"
+}
+
+For an unsuccessful build:
+{
+    "build_successful": "No",
+    "action": {
+        "type": "create|edit",
+        "file_path": "path/to/file",
+        "description": "Detailed description of the action and why it's needed"
+    }
+}
+Examples to clarify:
+{
+    "build_successful": "No",
+    "action": {
+        "type": "create",
+        "file_path": "path/to/file",
+        "description": "Detailed description of the action and why it's needed"
+    }
+}
+
+{
+    "build_successful": "No",
+    "action": {
+        "type": "edit",
+        "file_path": "path/to/file",
+        "description": "Detailed description of the action and why it's needed"
+    }
+}

app/workflow_executors/step_executors/impl/next_js_server_test_executor.go

@@ -14,8 +14,8 @@ import (
 	"os/exec"
 	"path/filepath"
 	"strings"
-
 	"go.uber.org/zap"
+	"ai-developer/app/monitoring"
 )
 
 type NextJsServerStartTestExecutor struct {
@@ -26,6 +26,7 @@ type NextJsServerStartTestExecutor struct {
 	llmAPIKeyService     *services.LLMAPIKeyService
 	storyService         *services.StoryService
 	projectService       *services.ProjectService
+	slackAlert           *monitoring.SlackAlert
 }
 
 func NewNextJsServerStartTestExecutor(
@@ -36,6 +37,7 @@ func NewNextJsServerStartTestExecutor(
 	executionService *services.ExecutionService,
 	storyService *services.StoryService,
 	projectService *services.ProjectService,
+	slackAlert           *monitoring.SlackAlert,
 ) *NextJsServerStartTestExecutor {
 	return &NextJsServerStartTestExecutor{
 		executionStepService: executionStepService,
@@ -45,6 +47,7 @@ func NewNextJsServerStartTestExecutor(
 		executionService:     executionService,
 		storyService:         storyService,
 		projectService:       projectService,
+		slackAlert:           slackAlert,
 	}
 }
 
@@ -170,46 +173,68 @@ func (e NextJsServerStartTestExecutor) Execute(step steps.ServerStartTestStep) e
 
 func (e NextJsServerStartTestExecutor) AnalyseBuildLogs(buildLogs, directoryPlan, apiKey string, step steps.ServerStartTestStep) (bool, map[string]interface{}, error) {
 	e.logger.Info("____Analyzing build logs____ ", zap.String("buildLogs", buildLogs))
-	messages, err := e.CreateMessage(buildLogs, directoryPlan)
-	if err != nil {
-		return false, nil, err
-	}
-	claudeClient:= llms.NewClaudeClient(apiKey)
-	response, err := claudeClient.ChatCompletion(messages)
-	if err != nil {
-		settingsUrl := config.Get("app.url").(string) + "/settings"
-		err = e.activityLogService.CreateActivityLog(
-			step.Execution.ID,
-			step.ExecutionStep.ID,
-			"INFO",
-			fmt.Sprintf("Action required: There's an issue with your LLM API Key. Ensure your API Key for %s is correct. <a href='%s' style='color:%s; text-decoration:%s;'>Settings</a>", constants.CLAUDE_3, settingsUrl, "blue", "underline"),
-		)
-		if err != nil {
-			fmt.Printf("Error creating activity log: %s\n", err.Error())
-			return false, nil, err
+	claudeClient := llms.NewClaudeClient(apiKey)
+	var jsonResponse map[string]interface{}
+	var response string
+
+	for retryCount := 1; retryCount < 6; retryCount++ {
+		messages, err := e.CreateMessage(buildLogs, directoryPlan, retryCount)
+		if err != nil{
+			fmt.Println("failed to create messages for llm")
+            return false, nil, err
 		}
-		//Update Execution Status and Story Status
-		if err = e.storyService.UpdateStoryStatus(int(step.Story.ID), constants.InReviewLLMKeyNotFound); err != nil {
-			fmt.Printf("Error updating story status: %s\n", err.Error())
-			return false, nil, err
+		response, err = claudeClient.ChatCompletion(messages)
+		if err != nil {
+			settingsUrl := config.Get("app.url").(string) + "/settings"
+			err = e.activityLogService.CreateActivityLog(
+				step.Execution.ID,
+				step.ExecutionStep.ID,
+				"INFO",
+				fmt.Sprintf("Action required: There's an issue with your LLM API Key. Ensure your API Key for %s is correct. <a href='%s' style='color:%s; text-decoration:%s;'>Settings</a>", constants.CLAUDE_3, settingsUrl, "blue", "underline"),
+			)
+			if err != nil {
+				fmt.Printf("Error creating activity log: %s\n", err.Error())
+				return false, nil, err
+			}
+			//Update Execution Status and Story Status
+			if err = e.storyService.UpdateStoryStatus(int(step.Story.ID), constants.InReviewLLMKeyNotFound); err != nil {
+				fmt.Printf("Error updating story status: %s\n", err.Error())
+				return false, nil, err
+			}
+			if err = e.executionService.UpdateExecutionStatus(step.Execution.ID, constants.InReviewLLMKeyNotFound); err != nil {
+				fmt.Printf("Error updating execution step: %s\n", err.Error())
+				return false, nil, err
+			}
+			fmt.Println("failed to generate code from llm")
+			if retryCount == 4 {
+				return false, nil, fmt.Errorf("failed to generate code from llm after 5 attempts: %w", err)
+			}
+			continue
 		}
-		if err = e.executionService.UpdateExecutionStatus(step.Execution.ID, constants.InReviewLLMKeyNotFound); err != nil {
-			fmt.Printf("Error updating execution step: %s\n", err.Error())
-			return false, nil, err
+		if err = json.Unmarshal([]byte(response), &jsonResponse); err != nil {
+			fmt.Println("failed to unmarshal response from Claude API, retrying...")
+			if retryCount == 5 {
+				err := e.slackAlert.SendAlert(
+					"Max retry limit reached while parsing JSON, error occurred while parsing build logs response",
+					map[string]string{
+						"story_id":          fmt.Sprintf("%d", int64(step.Story.ID)),
+						"execution_id":      fmt.Sprintf("%d", int64(step.Execution.ID)),
+						"execution_step_id": fmt.Sprintf("%d", int64(step.ExecutionStep.ID)),
+						"is_re_execution":   fmt.Sprintf("%t", step.Execution.ReExecution),
+					})
+				if err != nil {
+					fmt.Printf("Error sending slack alert: %s\n", err.Error())
+					return false, nil, err
+				}
+				return false, nil, fmt.Errorf("failed to unmarshal response from Claude API after 5 attempts: %w", err)
+			}
+			continue
 		}
-		fmt.Println("failed to generate code from llm")
-		return false, nil, fmt.Errorf("failed to generate code from llm: %w", err)
-	}
-	var jsonResponse map[string]interface{}
-	if err = json.Unmarshal([]byte(response), &jsonResponse); err != nil {
-		fmt.Println("failed to unmarshal response from Claude API, Failed to parse response as JSON on attempt.")
-		return false, nil, fmt.Errorf("failed to unmarshal response from Claude API: %w", err)
+		break
 	}
-	fmt.Println("Response after extracting JSON: ", jsonResponse)
+
 	buildResponse, action := e.CheckBuildResponse(jsonResponse)
-	fmt.Println("Build Logs Check Response")
 	return buildResponse, action, nil
-
 }
 
 func (e NextJsServerStartTestExecutor) CheckBuildResponse(response map[string]interface{}) (bool, map[string]interface{}) {
@@ -230,8 +255,20 @@ func (e NextJsServerStartTestExecutor) CheckBuildResponse(response map[string]in
 	return false, action
 }
 
-func (e NextJsServerStartTestExecutor) CreateMessage(buildLogs string, directoryPlan string) ([]llms.ClaudeChatCompletionMessage, error) {
-	content, err := os.ReadFile("/go/prompts/nextjs/next_js_build_checker.txt")
+func (e NextJsServerStartTestExecutor) CreateMessage(buildLogs string, directoryPlan string, attempts int) ([]llms.ClaudeChatCompletionMessage, error) {
+	var content []byte
+	var err error
+	if attempts > 1 {
+		content, err = os.ReadFile("/go/prompts/nextjs/next_js_build_checker_retry.txt")
+		if err!= nil {
+            return nil, fmt.Errorf("failed to load system prompt: %w", err)
+        }
+	} else {
+		content, err = os.ReadFile("/go/prompts/nextjs/next_js_build_checker.txt")
+		if err!= nil {
+            return nil, fmt.Errorf("failed to load system prompt: %w", err)
+        }
+	}
 	modifiedContent := strings.Replace(string(content), "{{BUILD_LOGS}}", buildLogs, -1)
 	modifiedContent = strings.Replace(string(modifiedContent), "{{DIRECTORY_STRUCTURE}}", directoryPlan, -1)
 	if err != nil {