Skip to content

Allow conditioning with tuples with more than one element #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Mar 18, 2025

Closes #848

This PR also adds changelog entries for previous patch releases

Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely; thanks @penelopeysm !

@penelopeysm penelopeysm enabled auto-merge March 18, 2025 15:09
Copy link
Contributor

Benchmark Report for Commit 1b5bc8d122ca50a601ef4e146297cdac38e8b6bc

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.1 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                588.9 |                42.0 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                341.8 |                55.9 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1255.4 |                25.5 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3521.0 |                21.7 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1392.8 |                30.0 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                896.2 |                 5.4 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5313.7 |                 5.1 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1040.0 |                 8.4 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              58546.7 |                 4.4 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8660.7 |                 9.6 |
|               Dynamic |        10 |    mooncake |             typed |   true |                125.5 |                11.9 |
|              Submodel |         1 |    mooncake |             typed |   true |                 23.8 |                 7.8 |
|                   LDA |        12 | reversediff |             typed |   true |                453.4 |                 4.6 |

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (e331523) to head (1b5bc8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #849   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files          34       34           
  Lines        3840     3840           
=======================================
  Hits         3241     3241           
  Misses        599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 18, 2025

Pull Request Test Coverage Report for Build 13926536078

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.489%

Totals Coverage Status
Change from base Build 13923779341: 0.0%
Covered Lines: 3241
Relevant Lines: 3836

💛 - Coveralls

@penelopeysm penelopeysm added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 48aca59 Mar 18, 2025
19 checks passed
@penelopeysm penelopeysm deleted the py/condition branch March 18, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditioning fails with tuple of pair
3 participants