Lower min support bash 3.0 #470
Draft
+108
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
reviewed
Aug 2, 2025
| @@ -239,7 +239,7 @@ function helpers::find_total_tests() { | |||
| for fn_name in "${functions_to_run[@]}"; do | |||
| local provider_data=() | |||
There was a problem hiding this comment.
In Bash 3.0, this doesn't work. This is equivalent to local provider_data='()' and creates a scalar variable containing the string '()' in Bash 3.0.
I just noticed this by looking at the diff, but I haven't checked the entire codebase. There could still be other compatibility issues.
There was a problem hiding this comment.
Thanks for the feedback. I didn't tested with real bash 3.0 binary as I had to leave after I created the PR and wanted to know how far away from the final result this would be. I will continue with it and test it with bash 3.0 binary this weekend. Also, I should find a way to setup this bash 3.0 in the CI to run all tests using that version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Right now the min supported version is bash 3.2
🔖 Changes
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix